ft: rcemipii vertical mesh#4172
Closed
haakon-e wants to merge 1 commit into
Closed
Conversation
Member
Author
|
This change is part of the following stack: Change managed by git-spice. |
Member
Author
|
cc: @oalcabes |
Member
|
I'm not sure if it's a good idea to specify predefined meshes for different setups. It may be ok if we just add RCEMIP, but what if someone wants to add more specific setups in the future? If we do want to support this, I think it would be better to add the functionality to read an array of numbers for the vertical mesh from yaml. This is just a thought, I would be interested in what others think. |
Member
Author
|
yeah I agree. I am hoping I can wait until Nat gets the new interface merged so that I can (hopefully) define the mesh only in my simulation setup instead of "polluting" the shared simulation setup functions |
bafc1bc to
7bacb1e
Compare
d26fd04 to
7159df2
Compare
Merged
7159df2 to
02e78f4
Compare
8b328e1 to
1f322e8
Compare
02e78f4 to
a4e8d62
Compare
8e623de to
d8ddcfd
Compare
a4e8d62 to
307d5d8
Compare
307d5d8 to
9d82dcf
Compare
fe63cd6 to
a0b31ad
Compare
9d82dcf to
6cebf16
Compare
a0b31ad to
cf775cf
Compare
c05f9fc to
bc7cf61
Compare
a614d5c to
1a89156
Compare
1a89156 to
310127f
Compare
Member
Author
|
Closed. Equivalent features implemented in #4236 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for selecting a predefined vertical mesh in the model configuration, specifically enabling the use of the "rcemipii" vertical mesh. The changes allow users to specify a vertical mesh type in the configuration files, and the codebase is updated to construct the appropriate mesh based on this setting.
Vertical mesh configuration and support:
vertical_meshconfiguration option indefault_config.ymlto allow users to select the predefined "rcemipii" mesh.rcemipii_box_CRM_1M.ymlmodel configuration to use the newvertical_mesh: rcemipiioption, and adjusted related vertical grid parameters (z_max,z_elem) to match the new mesh.Codebase enhancements for mesh construction:
BoxGridfunction ingrids.jlto accept avertical_meshargument and construct the "rcemipii" mesh when specified, using a hardcoded boundary layer and uniform spacing in the free atmosphere.get_gridfunction intype_getters.jlto pass thevertical_meshparameter from parsed arguments to the grid constructor.