Repository navigation
Fix. ContactEncoder. Edit to the tag attribute definition - #906
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #906 +/- ##
============================================
+ Coverage 32.45% 32.69% +0.23%
- Complexity 6948 6955 +7
============================================
Files 296 296
Lines 27216 27231 +15
============================================
+ Hits 8833 8903 +70
+ Misses 18383 18328 -55 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The title sanitization issue must be addressed before approval.
2 open findings
What changed in this PR
This PR updates ContactEncoder title handling to preserve HTML attributes while removing duplicate plain-text contacts and sanitizing rendered titles.
Changes:
- Processes text separately from HTML markup.
- Applies
wp_kses_post()to title output. - Preserves HTML during contact removal.
| File | Summary | Findings |
|---|---|---|
lib/Cleantalk/ApbctWP/ContactsEncoder/Shortcodes/ExcludedEncodeContentSC.php |
Updates HTML-aware contact stripping and title sanitization. | Moderate issue: sanitization may strip required encoder metadata on supported WordPress versions. Nit: add integration coverage for HTML attributes. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Glomberg
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


https://app.doboard.com/1/task/58990