Skip to content

Fix. ContactEncoder. Edit to the tag attribute definition - #906

Merged
AntonV1211 merged 4 commits into
devfrom
vuln_kses_av
Oct 13, 2026
Merged

AntonV1211 merged 4 commits into
devfrom
vuln_kses_av

Conversation

@AntonV1211

Copy link
Copy Markdown
Contributor

@codecov

codecov Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 32.69%. Comparing base (bd5c0cf) to head (d05b8d0).

Files with missing lines Patch % Lines
...actsEncoder/Shortcodes/ExcludedEncodeContentSC.php 95.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #906      +/-   ##
============================================
+ Coverage     32.45%   32.69%   +0.23%     
- Complexity     6948     6955       +7     
============================================
  Files           296      296              
  Lines         27216    27231      +15     
============================================
+ Hits           8833     8903      +70     
+ Misses        18383    18328      -55     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The title sanitization issue must be addressed before approval.

2 open findings
What changed in this PR

This PR updates ContactEncoder title handling to preserve HTML attributes while removing duplicate plain-text contacts and sanitizing rendered titles.

Changes:

  • Processes text separately from HTML markup.
  • Applies wp_kses_post() to title output.
  • Preserves HTML during contact removal.
File Summary Findings
lib/​Cleantalk/​ApbctWP/​ContactsEncoder/​Shortcodes/​ExcludedEncodeContentSC.php Updates HTML-aware contact stripping and title sanitization. Moderate issue: sanitization may strip required encoder metadata on supported WordPress versions. Nit: add integration coverage for HTML attributes.

🧠 Review effort: Lite


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread lib/Cleantalk/ApbctWP/ContactsEncoder/Shortcodes/ExcludedEncodeContentSC.php Outdated
@AntonV1211
AntonV1211 requested a review from Glomberg October 12, 2026 12:24
@AntonV1211
AntonV1211 merged commit 31122c0 into dev Oct 13, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants