Repository navigation
Fix. Code. Replacing the first occurrence of the search only in the element text - #905
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #905 +/- ##
============================================
+ Coverage 32.45% 32.69% +0.23%
- Complexity 6948 6955 +7
============================================
Files 296 296
Lines 27216 27231 +15
============================================
+ Hits 8833 8903 +70
+ Misses 18383 18328 -55 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The standalone ContactsEncoder asset still uses the old replacement logic and must be updated.
1 open finding
What changed in this PR
Updates email decoding to replace only text-node content, preserving markup and attributes.
Changes:
- Added text-node replacement logic.
- Updated public bundles and admin artifacts.
- Regenerated the source map.
| File | Reviewed change |
|---|---|
js/src/common-decoder.js |
Updated decoder; standalone ContactsEncoder asset still needs the same fix. |
js/prebuild/apbct-public-bundle.js |
Updated generated bundle. |
js/prebuild/apbct-public-bundle_int-protection.js |
Updated generated bundle. |
js/prebuild/apbct-public-bundle_int-protection_gathering.js |
Updated generated bundle. |
js/prebuild/apbct-public-bundle_gathering.js |
Updated generated bundle. |
js/prebuild/apbct-public-bundle_full-protection.js |
Updated generated bundle. |
js/prebuild/apbct-public-bundle_full-protection_gathering.js |
Updated generated bundle. |
js/prebuild/apbct-public-bundle_ext-protection.js |
Updated generated bundle. |
js/prebuild/apbct-public-bundle_ext-protection_gathering.js |
Updated generated bundle. |
js/cleantalk-admin.min.js.map |
Regenerated source map. |
js/cleantalk-admin.min.js |
Updated minified admin bundle. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Glomberg
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.doboard.com/1/task/59626