Skip to content

Fix. Settings. Fix notice appear on subsite on wpms. - #760

Merged
svedge merged 2 commits into
devfrom
fix-wpms-outofscope-notices
Oct 26, 2026
Merged

svedge merged 2 commits into
devfrom
fix-wpms-outofscope-notices

Conversation

@svedge

@svedge svedge commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The stored-key guard prevents individual-key provisioning when a subsite switches from shared-key mode with the network key saved locally.

1 open issue
What changed in this PR

This PR adjusts WordPress multisite settings behavior to hide errors managed at the network level from subsite administrators and avoid redundant access-key provisioning.

Changes:

  • Filter network-scoped errors, including nested cron errors, according to the multisite work mode.
  • Skip automatic individual-key provisioning when a subsite already has a stored key.
File Description
inc/​spbc-settings.php Adds work-mode-aware filtering for network-scoped errors on subsites.
inc/​spbc-admin.php Adds a stored-key guard to automatic subsite key provisioning.

Review effort: Balanced

Comment thread inc/spbc-admin.php Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused changes align with multisite error handling and key provisioning, with no unresolved blocking findings.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@svedge
svedge requested a review from Glomberg October 23, 2026 07:30
@svedge
svedge merged commit 4e78b21 into dev Oct 26, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants