Repository navigation
New. Security. Lost-password interface is under rate limit. - #755
Merged
Glomberg merged 13 commits intoOct 9, 2026
Merged
Conversation
…word-interfase-is-under-rate-limit-VI
…word-interfase-is-under-rate-limit-VI
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Rate-limit enforcement and handling of protection settings contain unresolved correctness issues.
4 open findings
What changed in this PR
Extends password-recovery protection using the plugin’s shared rate limiter.
Changes:
- Adds lost-password rate limiting and a settings notice.
- Identifies clients by IP and request type rather than user agent.
- Adds persisted lock timestamps and atomic database updates.
| File | Description |
|---|---|
| lib/CleantalkSP/SpbctWP/SpbcRateLimit/SpbcRateLimiter.php | Updates counters, locks, state refresh, and cleanup. |
| lib/CleantalkSP/SpbctWP/DB/SQLSchema.php | Adds the locked_at column. |
| lib/CleantalkSP/Common/RateLimit/RateLimiter.php | Changes client identification and lock checks. |
| lib/CleantalkSP/Common/RateLimit/RateLimitDTO.php | Adds lock timestamp data. |
| js/src/react/components/TabContent/TabSettingsGeneral/Settings/BfpEnabled.js | Adds the password-recovery protection notice. |
| inc/spbc-auth.php | Hooks password-recovery requests into rate limiting. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
AntonV1211
approved these changes
Oct 9, 2026
…word-interfase-is-under-rate-limit-VI # Conflicts: # js/public/spbct-react-bundle.js
Glomberg
deleted the
New-Security-Lost-password-interfase-is-under-rate-limit-VI
branch
October 9, 2026 07:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.doboard.com/1/task/56971