Repository navigation
Fix. Code. Optimizing the parsing of approved hashes https://app.doboard.com/1/task/57727 - #742
Merged
Merged
Conversation
AntonV1211
changed the title
Fix. HeuristicAnalyser. Remove is_callable check
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
One or more issues must be addressed before approval.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Optimizes scanner file filtering and remote approved/denied hash processing by streaming decompression and batching database queries.
Changes:
- Adds chunked remote hash reading and batched status updates.
- Optimizes binary signature checks and path handling.
- Replaces per-file full-hash queries with batch lookup.
| File | Description |
|---|---|
| lib/CleantalkSP/SpbctWP/Scanner/Surface.php | Updated as part of this pull request. |
| lib/CleantalkSP/SpbctWP/Scanner/ScannerQueue.php | Updated as part of this pull request. |
| lib/CleantalkSP/SpbctWP/Scanner/RemoteHashesReader.php | Updated as part of this pull request. |
| lib/CleantalkSP/SpbctWP/Scanner/Helper.php | Updated as part of this pull request. |
| lib/CleantalkSP/SpbctWP/Scanner/BinaryCheckModule/BinaryCheckModule.php | Updated as part of this pull request. |
| lib/CleantalkSP/Common/Helpers/CSV.php | Updated as part of this pull request. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Glomberg
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.doboard.com/1/task/57727