Skip to content

Update June 2026 API fixtures#1

Open
MagicTheDev wants to merge 1 commit into
mainfrom
feat/june26
Open

Update June 2026 API fixtures#1
MagicTheDev wants to merge 1 commit into
mainfrom
feat/june26

Conversation

@MagicTheDev

Copy link
Copy Markdown
Member

Summary

  • Update MockAPI battlelog schema and fixtures for the June 2026 Clash of Clans API fields, including uppercase battle types, Legend battle entries, opponent details, battle duration, and battle timestamp.
  • Refresh league/CWL fixtures for full-date season identifiers, Legend tier naming, ranked player leagueTier, current war duration, and current battle modifier values.
  • Add focused unittest coverage for the changed response fixtures and generated OpenAPI schema.

Validation

  • uv run python -m unittest discover -s tests
  • python3 -m unittest discover -s tests
  • python3 -m compileall app tests
  • git diff --check

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 706052149a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +35 to +37
"small": "https://api-assets.clashofclans.com/leagues/72/R2zmhyqQ0_lKcDR5EyghXCxgyC9mm_mVMIjAbmGoZtw.png",
"tiny": "https://api-assets.clashofclans.com/leagues/36/R2zmhyqQ0_lKcDR5EyghXCxgyC9mm_mVMIjAbmGoZtw.png",
"medium": "https://api-assets.clashofclans.com/leagues/288/R2zmhyqQ0_lKcDR5EyghXCxgyC9mm_mVMIjAbmGoZtw.png"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use league-tier icon assets in player rankings

For /locations/{id}/rankings/players, the newly added leagueTier object for Legend I reuses the legacy league.iconUrls (/leagues/...) instead of the tier-specific assets. The same tier in LISTLEAGUETIERS.json and the league-season rankings fixture uses /leaguetiers/..., so clients testing ranking UI against this endpoint will receive inconsistent artwork for the same leagueTier.id and can render the wrong badge.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant