feat: move api to go sql branch#30
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 390017bb1e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,115 +0,0 @@ | |||
| import sentry_sdk | |||
There was a problem hiding this comment.
Deleting main.py leaves the stable container unable to start: .github/workflows/main.yml still selects Dockerfile for stable tags, and that Dockerfile still runs CMD ["python", "main.py"]. Any non-beta release built from this commit will exit immediately with a missing file instead of serving the new Go API.
Useful? React with 👍 / 👎.
| set_clan = EXCLUDED.set_clan, | ||
| data = EXCLUDED.data, | ||
| updated_at = now() | ||
| `, fmt.Sprint(asInt64(ticket["server"])), serverAsString(ticket["channel"]), serverAsString(ticket["panel"]), serverAsString(ticket["status"]), serverAsString(ticket["user"]), serverAsString(ticket["set_clan"]), apptypes.Marshal(ticket), ticket["created_at"]) |
There was a problem hiding this comment.
When updating an existing open ticket, openTicketGet/openTicketScan stores ticket["server"] as a string, but this save path converts it with asInt64, which does not handle strings and returns 0. The status/clan update endpoints therefore upsert (server_id=0, channel_id=...) instead of modifying the requested server's ticket, so the API returns success while the original ticket remains unchanged.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bf8e5f1b19
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if err := insertEmailVerification(c.UserContext(), a, record); err != nil { | ||
| return err | ||
| } | ||
| return apptypes.JSON(c, fiber.StatusOK, map[string]any{ |
There was a problem hiding this comment.
In non-local deployments localCode returns nil, and this handler now stores the verification code but never sends it before telling the user to check their email. That leaves new email registrations unable to complete /verify-email-code because the 6-digit code is neither returned nor delivered; the same missing delivery pattern affects resend/password-reset flows that rely on emailed codes.
Useful? React with 👍 / 👎.
2 participants
No description provided.