Update GovBanner Component#332
Open
sreidthomas wants to merge 17 commits into
Open
Conversation
…trol margin in light-DOM
jedgar1mx
reviewed
Apr 21, 2025
Member
jedgar1mx
left a comment
jedgar1mx
left a comment
There was a problem hiding this comment.
The child element should not have the aria-expanded attribute
maxatdetroit
suggested changes
Apr 28, 2025
Contributor
maxatdetroit
left a comment
maxatdetroit
left a comment
There was a problem hiding this comment.
Just a couple small tweaks requested. Nice work.
…hanges in govbanner file and fixed alignment issue on the right side of component when expanded and not expanded
maxatdetroit
suggested changes
May 6, 2025
Contributor
maxatdetroit
left a comment
maxatdetroit
left a comment
There was a problem hiding this comment.
I'm not sure what changed but the animation is now very jerky and the background color of the content area is incorrect on the left/right. Would you please correct those things?
Screen.Recording.2025-05-06.101537.mp4
Contributor
Author
2025-05-22.13-43-55.mp4 |
maxatdetroit
suggested changes
Jun 24, 2025
Contributor
maxatdetroit
left a comment
maxatdetroit
left a comment
There was a problem hiding this comment.
@sreidthomas could you merge in dev and resolve the conflicts? Sorry for the conflicts. I had to make some nontrivial changes in #350 to support a feature for the site launch this week.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GovBanner needed some updates to improve styles and behavior
partattribute enabling it to be styled from the light DOM. Specifically, I should be able to override the left and right margins of the content so that the edges line up with the main content of the site where the banner is used.