fix(news): replace dead BIG10 RSS URL, upgrade HTTP feeds to HTTPS#112
fix(news): replace dead BIG10 RSS URL, upgrade HTTP feeds to HTTPS#1125ymb01 wants to merge 1 commit intoChuckBuilds:mainfrom
Conversation
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughDefault predefined RSS feed URLs in the news plugin are updated: ESPN MLB and NFL sources switch from HTTP to HTTPS, and the BIG10 feed source is redirected from a Big Ten blog RSS endpoint to the ESPN NCAA Football news endpoint. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 57 minutes and 44 seconds.Comment |
- BIG10 feed pointed to espn.com/blog/feed?blog=bigten which returns HTML (not RSS XML), causing XML parse errors on every update cycle. Replaced with ESPN college football RSS which covers Big Ten content. - MLB and NFL feeds used http:// URLs causing unnecessary 301 redirects. Upgraded to https://www.espn.com canonical URLs. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
5ymb01
force-pushed
the
fix/news-rss-feeds
branch
from
f7de01b to
9560edf
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@plugins/news/manager.py`:
- Line 59: The BIG10 entry in the RSS mapping now points to the same URL as NCAA
FB, causing duplicate headlines; fix by either (A) restoring or removing BIG10:
update the mapping key 'BIG10' to the correct conference-specific RSS URL (or
remove it and add a deprecation comment/README note) so it no longer equals the
'NCAA FB' URL, or (B) keep both keys but add URL-level deduplication in the news
fetch/update code (e.g., inside the functions that aggregate feeds such as
fetch_and_update_headlines or fetch_feed_urls) to filter identical feed URLs and
dedupe items by canonical URL/guid before inserting, and update the README to
reflect the chosen approach.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b6906410-9dba-4725-8303-141ea0d52760
📒 Files selected for processing (1)
plugins/news/manager.py
| 'NCAA FB': 'https://www.espn.com/espn/rss/ncf/news', | ||
| 'NHL': 'https://www.espn.com/espn/rss/nhl/news', | ||
| 'NBA': 'https://www.espn.com/espn/rss/nba/news', | ||
| 'TOP SPORTS': 'https://www.espn.com/espn/rss/news', | ||
| 'BIG10': 'https://www.espn.com/blog/feed?blog=bigten', | ||
| 'BIG10': 'https://www.espn.com/espn/rss/ncf/news', |
There was a problem hiding this comment.
BIG10 now points to the same feed as NCAA FB, causing semantic drift and possible duplicate headlines.
At Line 59, BIG10 now resolves to ncf/news, which is already used by NCAA FB (Line 55). If both are enabled, users can get duplicated content and BIG10 no longer represents conference-specific headlines. Please either (a) rename/deprecate BIG10, or (b) keep BIG10 and add URL-level deduping in fetch/update logic plus README alignment.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@plugins/news/manager.py` at line 59, The BIG10 entry in the RSS mapping now
points to the same URL as NCAA FB, causing duplicate headlines; fix by either
(A) restoring or removing BIG10: update the mapping key 'BIG10' to the correct
conference-specific RSS URL (or remove it and add a deprecation comment/README
note) so it no longer equals the 'NCAA FB' URL, or (B) keep both keys but add
URL-level deduplication in the news fetch/update code (e.g., inside the
functions that aggregate feeds such as fetch_and_update_headlines or
fetch_feed_urls) to filter identical feed URLs and dedupe items by canonical
URL/guid before inserting, and update the README to reflect the chosen approach.
There was a problem hiding this comment.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
2 participants
Summary
The News Ticker plugin's
BIG10feed URL pointed toespn.com/blog/feed?blog=bigten, which now returns HTML instead of RSS XML, causing XML parse errors on every update cycle. Additionally, theMLBandNFLfeeds usedhttp://URLs that 301-redirect tohttps://, adding latency and a redirect hop on every fetch.Type of change
Plugin(s) affected
newsRelated issues
N/A — no existing issue.
Test plan
curl:espn.com/blog/feed?blog=bigten): returns 301 + HTML, not RSSespn.com/espn/rss/ncf/news): 200, valid RSS XMLhttp://espn.com/...): 301 redirecthttps://www.espn.com/...): 200 directRequired for plugin changes
versioninplugins/news/manifest.json(1.0.4 → 1.0.5)class_namematches actual classentry_pointmatches the real fileREADME.mddoes not need updates (no config keys changed)config_schema.jsonunchanged (defaults are internal)update_registry.pyran successfully (plugins.jsonupdated)Checklist
CONTRIBUTING.mdCONTRIBUTING.mdandCODE_OF_CONDUCT.mdNotes for reviewer
The replacement BIG10 feed is the general ESPN college football RSS rather than a Big-Ten-specific one — ESPN no longer publishes a Big-Ten-only RSS feed that I could find. Open to alternative URLs if you know of a better one.
Summary by CodeRabbit
Bug Fixes
Updates