Revive observe observability primitive (#81)#142
Merged
Conversation
Port the issue #81 observe primitive onto current dev while preserving the current schema v9 delivery store behavior, terminal dead suppression, redrive logic, and verify.sh environment handling. Includes offline redb snapshot reads plus the transient live observe socket for supervise-owned redb handles from ceb6d48. Verification: cargo fmt --all; cargo build -p fkst-framework; cargo test -p fkst-framework observe; cargo test -p fkst-framework delivery_store; real observe --json smoke against a generated durable store. ⟦AI:FKST⟧
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revive the
observeobservability primitive (#81)#81 (the generic
observe --jsonCLI dumping per-entity timeline + queue/DLQ state from the redb durable store) was auto-implemented on a devloop branch, but its PR #84 was CLOSED/reaped when the parent issue was driven toblockedby a fix-loop timeout (~28h) — not a merit rejection. The primitive never landed in dev, sofkst-framework observe --json(andscripts/run.sh health/ the local board) are currently broken ("unknown subcommand: observe").This integrates the primitive (commits f39800a + ceb6d48) onto current dev:
crates/fkst-framework/src/observe.rs— theobservesubcommandsrc/supervise/delivery_store.rs— the snapshot reader, merged with current dev's schema-v9 delivery store (redrive, terminal dead-letter suppression, compaction) preservedsrc/supervise/observe_server.rs— live observe socket for a running supervisecrates/fkst-common/src/durable_layout.rs,src/main.rs,src/supervise/mod.rsOutput contract (stable)
fkst-framework observe --durable-root <root> --json→DeliveryObserveSnapshot:{ schema_version:1, generated_at_ms, source{...}, limits{...}, truncated{deliveries,dead_letters}, queues[{queue,depth,pending,in_flight,retrying,oldest_pending_age_ms}], deliveries[...], dead_letters[...] }Verification
cargo build -p fkst-framework✓cargo test -p fkst-framework observe✓ ; delivery_store tests 54/0 ✓cargo fmt --all --check✓delivery.redband ranobserve --durable-root <root> --json→ emitsschema_version:1+ the full contract.Why now
A downstream packages feature (idle-detector + archaudit: idle-triggered read-only architecture audit) depends on this
observecontract. It is implemented and CI-green against this exact shape but fail-closed-inert untilobserveis back in dev.🤖 Generated with Claude Code
⟦AI:FKST⟧