Skip to content

Codex overall-timeout (3600s) not enforced: implement codex hung 11h on quiet scripts/run.sh test, freezing the devloop pipeline (open_pr 0 success); suspect #135 flush blocks the timeout wait loop#140

Closed
loning wants to merge 1 commit into
integrationfrom
devloop/issue/ChronoAIProject/fkst-substrate/139/ready-consensus-github-devloop-issue-ChronoAIProject-fkst-substrate-139-intake-0744151715-loop-1-3286942947
Closed

Codex overall-timeout (3600s) not enforced: implement codex hung 11h on quiet scripts/run.sh test, freezing the devloop pipeline (open_pr 0 success); suspect #135 flush blocks the timeout wait loop#140
loning wants to merge 1 commit into
integrationfrom
devloop/issue/ChronoAIProject/fkst-substrate/139/ready-consensus-github-devloop-issue-ChronoAIProject-fkst-substrate-139-intake-0744151715-loop-1-3286942947

Conversation

@loning

@loning loning commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

github-devloop implementation PR for issue #139

…ement codex hung 11h on quiet `scripts/run.sh test`, freezing the devloop pipeline (open_pr 0 success); suspect #135 flush blocks t
@loning

loning commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

github-devloop implementation PR for issue #139

@loning

loning commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

github-devloop PR is ready for review

@loning loning added the fkst-dev:reviewing pr-review-consensus-in-progress label Jun 18, 2026
@loning

loning commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

github-devloop PR review decision: reject
Three-angle verdicts: minimal=reject structural=reject delete=reject
Blocking gap: Unfixed stdout-drain durable-publish deadlock path

minimal:
Established process-supervision practice requires a parent-owned monotonic watchdog outside child stdout/stderr drain and durable publish paths; this diff only bounds local spawn_codex_sync/adoption waits in sdk_codex.rs, while the producer context refined the accepted root to stdout_observer → publish_raised_events → router.publish blocking pipe drain, so the minimal accepted path still lacks proof or code that the DEFAULT_CODEX_TIMEOUT_SECONDS watchdog dominates the actual #135 drain/publish deadlock path.

structural:
Established process-supervision practice requires a parent-owned monotonic watchdog and nonblocking stdout/stderr drainage, with durable publication kept off the pipe-drain path; this diff mostly changes sdk_codex.rs timeout handling (run_codex_sync_request, try_lock_until_deadline, wait_codex_with_timeout_and_tail) but leaves the stated #135 deadlock boundary stdout_observerpublish_raised_eventsrouter.publish untouched, so the core data-flow and module-boundary violation can still freeze the child stdout drain before DEFAULT_CODEX_TIMEOUT_SECONDS is enforced.

delete:
Established process-supervision practice requires a parent-owned monotonic watchdog outside child I/O, buffering, durable publish, and adoption bookkeeping; the delete-angle bar is to remove or make nonblocking the unnecessary blocking surface, not add another wrapper around it. The diff adds run_codex_sync_request, bounded lock waiting, and timeout tests, but it does not delete, make no-op, or decouple the diagnosed stdout_observerpublish_raised_eventsrouter.publish durable-publish path that can block pipe draining and prevent the existing DEFAULT_CODEX_TIMEOUT_SECONDS/spawn_codex_sync watchdog from running, so the proposed surface does not prove necessity and leaves the class defect alive.

⟦AI:FKST⟧

@loning loning added fkst-dev:fixing review-rejected-and-fix-in-progress and removed fkst-dev:reviewing pr-review-consensus-in-progress labels Jun 18, 2026
@loning loning mentioned this pull request Jun 18, 2026
@loning loning closed this Jun 18, 2026
@loning

loning commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

github-devloop reaped this managed PR because its parent issue is terminal.

Parent: #139
Reason: Parent issue #139 is closed.
Successors: 0 successor issue(s)
Branch cleanup is intentionally left to a separate manual or managed path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fkst-dev:fixing review-rejected-and-fix-in-progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant