refactor(saga): convert rollup_scan to std.saga.department#1272
Merged
Conversation
Convert github-devloop rollup_scan to std.saga.department: done=false, act = old
pipeline body byte-for-byte (branches skip + with_lock + core.log_raise(devloop_rollup_ready)
+ helpers preserved in order), wrap=core.wrap_pipeline_failure name="rollup_scan".
The full spec is preserved: consumes, both produces in order, fanout = { "devloop_branch_tick" },
and stall_window. saga-handler.allowlist (G10 3->2).
Note: the first review round caught that the initial conversion DROPPED the spec
`fanout = { "devloop_branch_tick" }` field (a static-graph regression); it was restored
and the spec now matches origin exactly. An audit confirmed no prior merged saga slice
dropped a spec field (their originals had none). sshx-reviewed (re-review 3/3 approve);
full test 9 packages 0 failed.
⟦AI:FKST⟧
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0163uaeg6woT12QeZE1cAkn6
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert rollup_scan to std.saga.department: done=false, act = old body byte-for-byte, wrap preserved, log_raise unchanged. FULL spec preserved incl fanout = { devloop_branch_tick } (first review caught it dropped; restored). saga-handler 3->2. sshx re-review 3/3 approve; full test 9 packages 0 failed.
⟦AI:FKST⟧
🤖 Generated with Claude Code