TimeDelta::from_now ensures the execution is within critical section#9
Open
trnila wants to merge 1 commit intoChristopher-06:mainfrom
Open
TimeDelta::from_now ensures the execution is within critical section#9trnila wants to merge 1 commit intoChristopher-06:mainfrom
TimeDelta::from_now ensures the execution is within critical section#9trnila wants to merge 1 commit intoChristopher-06:mainfrom
Conversation
The `from_now` function must execute atomically within a critical section, as it modifies the global variable `LAST_TIMESTAMP`, which could lead to corrupted time deltas. Requiring `CriticalSection` in the function arguments ensures the caller is in critical section and its not used incorrectly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my stm32 app under the load, the deltas are sometimes corrupted - see
us_timeticksvalues jumped compared to loggedget_tracing_raw_ticksfor tick 9 and 10. Thedefmt_timestamp_sis also correct.The
TimeDelta::from_nowfunction must execute atomically within a critical section, as it modifies the global variableLAST_TIMESTAMP, which could lead to corrupted time deltas.Requiring
CriticalSectionin the function arguments ensures the caller is in critical section and its not used incorrectly.