Changed how commands are run to support Python 3, increase stability.#14
Changed how commands are run to support Python 3, increase stability.#14kingllama wants to merge 2 commits intoChristophe31:masterfrom
Conversation
|
it looks good to me, I'll pep8 some commas, try it and merge, I hope by next week. |
|
damned, I forgot you… sorry, I still have this tab open, I didn't forgot totally… =_= |
|
bump? |
|
It would be nice to get the updated version into pypi. |
|
I was sure this project was dead and every body was using tmux nowadays ^^… I'm sorry but I think you should pip install the fork, as I didn't test anything and don't see a world where I would be using this project again, I feel more honest by not updating it… If someone have an active fork, I may link it in the README… |
|
That works, but it would be nice just to be able to pip install it. Would you be willing to and @kingllama and/or myself to the pypi screenutils package so one of use could update it. (I'm Gerardw on pypi) |
Changed
commandsandos.systemin favour of thesubprocessmodule. Old versions are still supported, so this shouldn't break any code.commandsis completely gone in python 3 andos.systemhas long since been replaced bysubprocess.This adds a lot of stability as the process doesn't need to open a new shell to do anything, one of the major road blocks in getting tests in.
I've tested this in 3.4 and 2.7, but not in older versions (it should work fine as there are fallbacks for everything.)