refactoring: generic refactoring#37
Open
fyllekanin wants to merge 2 commits into
Open
Conversation
Collaborator
fyllekanin
commented
Aug 30, 2023
fyllekanin
commented
- Add file size limit to settings
- Remove unused variables
- Add "use" instead of using \
- Align vue files with 4 space indentation
- Add file size limit to settings - Remove unused variables - Add "use" instead of using \ - Align vue files with 4 space indentation
fyllekanin
commented
Aug 30, 2023
| fetchSlips() | ||
| } | ||
| const fetchSlips = async () => { | ||
| const next_url = slips.value.next_page_url |
Collaborator
Author
There was a problem hiding this comment.
Wondering if this check can't be done above "fetchSlips", seems like unneeded code to run if next_page_url either way will stop it further ahead in callbacks
| tooltip: { | ||
| delay: { | ||
| show: 100, | ||
| delay: 100, |
Collaborator
Author
There was a problem hiding this comment.
"delay" doesn't seem to be a supported delay property when looking at:
https://github.com/Akryum/floating-vue/blob/main/packages/floating-vue/src/config.ts
| delay: 100, | ||
| }, | ||
| }, | ||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.