refactor: remove Deflate pipeline and default to Lzf#117
Merged
Conversation
The Deflate pipeline (LZ77 + Huffman, ID 0) was neither gzip-compatible nor competitive with Lzf (LZ77 + FSE). Tombstone ID 0 following the established pattern of prior removals (Lz78R ID 7, Parlz ID 11). - Remove Pipeline::Deflate enum variant, tombstone ID 0 in TryFrom<u8> - Change default pipeline to Lzf in CLI, FFI, auto-selection, and scripts - Rename DEFLATE_MAX_MATCH → LZ77_MAX_MATCH (used broadly as default cap) - Delete throughput_deflate and stages_deflate_webgpu_chained benchmarks - Keep src/deflate.rs (RFC 1951 inflate for .gz decompression) - Keep src/huffman/ (used by LzSeqH pipeline) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
0482a0e to
0d476dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DEFLATE_MAX_MATCH→LZ77_MAX_MATCH(the constant is used broadly as a default cap, not just by Deflate)throughput_deflateandstages_deflate_webgpu_chainedbenchmarkssrc/deflate.rs(RFC 1951 inflate for.gzdecompression) andsrc/huffman/(used by LzSeqH)Test plan
./scripts/test.sh --quickpasses (fmt, clippy, 692 tests)pz -d file.gzstill works (gzip decompression path unchanged)pz -l old_deflate.pzshows"deflate (removed)"for legacy filespz file.txtdefaults to Lzf pipeline🤖 Generated with Claude Code