Remove LZ78 algorithm and Lz78R pipeline#116
Merged
Merged
Conversation
Benchmarking confirmed LZ78+rANS is uncompetitive: 34% slower throughput, 8-13x worse compression ratio, and 1.7x slower decompression vs Lzr. The gap is algorithmic (trie-based dictionary vs sliding window) and not fixable by tuning. LZ78's theoretical advantage (online/adaptive streaming) isn't leveraged since the streaming path uses independent blocks. Removes src/lz78.rs (315 lines), the Lz78R pipeline variant (ID 7, tombstoned like Parlz at ID 11), and all references across 18 files. Adds throughput_lzseqr benchmark and pipeline_comparison example that were created during the benchmarking investigation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/lz78.rs(315 lines) and theLz78Rpipeline (ID 7) across 18 filesthroughput_lzseqrbenchmark andpipeline_comparisonexample created during investigationTest plan
./scripts/test.sh --quickpasses (fmt, clippy, tests)--no-default-featureslz78/Lz78Rreferences in source (only tombstone comments)Err(Unsupported)on deserialization🤖 Generated with Claude Code