Skip to content

[Backend] Cover archived-board skip recovery #2637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chris0Jeky merged 1 commit into from
Sep 5, 2026
Merged

[Backend] Cover archived-board skip recovery #2637

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions backend/tests/Taskdeck.Application.Tests/Services/AutomationProposalServiceEdgeCaseTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,51 @@ public async Task ExpireProposalsAsync_ShouldLogArchivedBoardSkipOnlyOnCountTran
entry => entry.Level == LogLevel.Debug && entry.Message.Contains("Still skipping"));
}

[Fact]
public async Task ExpireProposalsAsync_ShouldLogWhenArchivedBoardSkipCountReturnsToZero()
{
var logger = new InMemoryLogger<AutomationProposalService>();
var service = new AutomationProposalService(
_unitOfWorkMock.Object,
_notificationServiceMock.Object,
provenanceRepository: null,
policyEngine: null,
logger: logger);
var expirable = CreatePendingProposal();

_proposalRepoMock
.SetupSequence(r => r.GetExpiredAsync(It.IsAny<CancellationToken>()))
.ReturnsAsync(new ExpiredProposalSweep(
Array.Empty<AutomationProposal>(),
SkippedArchivedBoardCount: 2))
.ReturnsAsync(new ExpiredProposalSweep(
new[] { expirable },
SkippedArchivedBoardCount: 0));

await service.ExpireProposalsAsync();
var result = await service.ExpireProposalsAsync();

result.IsSuccess.Should().BeTrue();
result.Value.Should().Be(1);
expirable.Status.Should().Be(ProposalStatus.Expired);
_unitOfWorkMock.Verify(
u => u.SaveChangesAsync(It.IsAny<CancellationToken>()),
Times.Once());
_notificationServiceMock.Verify(
s => s.PublishAsync(It.IsAny<CreateNotificationRequestDto>(), It.IsAny<CancellationToken>()),
Times.Once());

logger.Entries.Should().ContainSingle(
entry => entry.Level == LogLevel.Information
&& entry.Message.Contains("No stale proposals are being withheld"));
logger.Entries.Should().ContainSingle(
entry => entry.Level == LogLevel.Information
&& entry.Message.Contains("Skipped expiring")
&& entry.Message.Contains("2"));
logger.Entries.Should().NotContain(
entry => entry.Level == LogLevel.Debug && entry.Message.Contains("Still skipping"));
}

[Fact]
public async Task ExpireProposalsAsync_ShouldReturnZero_WhenNoneExpired()
{
Expand Down
Loading