Skip to content

refactor: use static toast label keys #2627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chris0Jeky merged 1 commit into from
Sep 5, 2026
+13 −1
Merged

refactor: use static toast label keys #2627

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion frontend/taskdeck-web/src/components/paper/PaperToastContainer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,18 @@ const FALLBACK_LABEL: Record<Toast['type'], ToastLabel> = {
info: 'noted',
}

/** Keep every supported toast label tied to a checked, static catalog key. */
const TOAST_LABEL_KEYS: Record<ToastLabel, string> = {
saved: 'shell.toast.label.saved',
queued: 'shell.toast.label.queued',
approved: 'shell.toast.label.approved',
applied: 'shell.toast.label.applied',
done: 'shell.toast.label.done',
noted: 'shell.toast.label.noted',
warning: 'shell.toast.label.warning',
failed: 'shell.toast.label.failed',
}

/** The outcome word this toast is stamped with — the caller's, else severity's. */
function labelKind(toast: Toast): ToastLabel {
return toast.label ?? FALLBACK_LABEL[toast.type]
Expand All @@ -99,7 +111,7 @@ function labelKind(toast: Toast): ToastLabel {
*/
function describe(toast: Toast): ToastDescriptor {
const kind = labelKind(toast)
const label = t(`shell.toast.label.${kind}`)
const label = t(TOAST_LABEL_KEYS[kind])
switch (toast.type) {
case 'success':
return { tone: 'applied', tagstamp: 'applied', glyph: '✓', labelKind: kind, label }
Expand Down
Loading