sweep/2026-10-12: 9H + 22M fixed, 7 new tests, 42 commits

[Chartres]

Findings

Sev	Found	Fixed	Skipped
H	9	9	0
M	~30	22	~8
L	~40	8	~32

Tests: 30 → 37 (+7 new)

Notable fixes

Crashes (H):

• src/ui/treemap_view.rs + dir_tree.rs — byte-slice on non-ASCII names panicked the UI thread (e.g. "Příliš.pdf"); now char-safe truncation
• src/app.rs — hovered_dir not reset on new scan → OOB index panic on first frame after scan completes
• src/app.rs — pending_action (Confirm Trash dialog) kept stale NodeIds across a rescan → trashed wrong path
• src/scanner/walk.rs — hard links counted once per link; <Hidden / Skipped> saturated to 0

Safety (H/M):

• src/cleanup.rs — suffix rules (Library/Caches, .cargo, etc.) matched anywhere in the path string; /x/MyLibrary/Caches was a false candidate; now component-boundary checked
• src/cleanup.rs — scan root itself was listed as a cleanup candidate; its Trash button bypassed the root guard
• src/app.rs — Cmd+⌫ keyboard shortcut bypassed the scan-root/synthetic-node guard added to the context menu
• src/cleanup.rs — .Trash offered as a candidate; its Trash button moved ~/.Trash into the Trash
• src/cleanup.rs — .m2/.gradle descriptions didn't mention credentials (settings.xml, keys)
• src/cleanup.rs — Docker description didn't warn about named volumes with non-regenerable data
• src/cleanup.rs — target rule flagged any directory named target, not just Rust builds; guarded by Cargo.toml presence
• src/app.rs — perform_delete had no is_alive check; stale ConfirmTrash trashed wrong path after partial refresh
• src/scanner/tree.rs — remove_node didn't guard against double-remove; double-subtracted sizes
• src/app.rs — zoom stack not sanitized on delete; trashing the zoomed-into dir left treemap blank

Correctness (M):

• src/ui/treemap_view.rs — selecting "(none)" extension dimmed extension-less files instead of lighting them
• src/ui/cleanup_window.rs — category headers repeated across size-sorted list; now sorted (category, size desc)
• src/app.rs — collect_files(root).len() walked entire tree every frame; replaced with node.file_count
• src/app.rs — batch/single trash failures only eprintln'd; now shown in status bar
• src/app.rs — poll_scan ignored Disconnected; a crashed walker thread left UI stuck on "Scanning…"
• src/app.rs — start_scan now resets pending_action, hovered_dir, partial_refresh_receiver, selected_extension
• src/app.rs — Confirm Delete dialog shows full path, not just truncated filename
• Context menu: Move to Trash suppressed for scan root and synthetic nodes (<Free Space>, <Hidden / Skipped>)

New tests:

• tests/cleanup_tests.rs — classify, find_candidates, .Trash exclusion, .rustup, iCloud, node_modules
• tests/walk_tests.rs — tempdir scan: file + subdir sizes
• tests/tree_tests.rs — remove_node double-dead guard

Refactors (6 commits)

• confirm_dialog helper for three trash confirmation modals (dedup ~100 lines)
• AppState::remove_trashed shares post-delete cleanup across single/batch (dedup ~20 lines)
• AppState::reset_dead_view_root deduped view/zoom cleanup across 3 call sites
• aggregate_dir helper deduped size-field writes across compute_sizes, recompute_sizes_upward, graft_under
• mark_descendants_dead — non-recursive, replaces recursive mark_dead_recursive + clear_descendants duplication
• Table-driven Cmd+1/2/3 color-mode shortcuts

Skipped (architectural, out of scope)

• Scan thread cancellation (M) — requires channel-based cooperative cancel plumbing
• Arena byte reclamation (L) — requires arena compaction
• st_blocks allocated-size (L) — OS-specific, needs careful sparse/special-file guards
• /System/Volumes scan root empty (L) — volume prefix skip logic needs restructure

---

🤖 Generated with Claude Code