Repository navigation
Fuzzing round 3: autostart takeover, held hotkeys, unwritable settings folder - #41
Merged
Merged
Conversation
…s folder - MicSwitch autostart takeover: an unquoted command whose folder has ".exe" inside a name (C:\Users\alex.exeter\...) was read as C:\Users\alex.exe, judged missing, and a working MicSwitch lost its autostart; ".exe" now has to end the name - Changing the hotkeys while one is held ends the hold: push-to-talk on a mouse button stayed live after letting go, and a held volume key kept repeating - A logs folder that can't be created no longer stops the app from starting; picking an icon and Open logs folder show a message instead of crashing - The hotkey fake now behaves like the hook (a release only reaches a registration that saw the press); tests for each case
- A longer hand-edited list is cut on load (AppSettings.Normalize); 1,000 rows froze the Hotkeys page for 33 s - Add is disabled at the cap, with a note saying why
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Matt · project thread
Before: a MicSwitch install in a folder with ".exe" inside a name (for example the user folder
alex.exeter) lost its autostart entry to MicControl even though MicSwitch was still there. If push-to-talk was held on a mouse button while a hotkey setting changed, the mic stayed live after the button was let go, and a held volume key kept repeating. If the logs folder couldn't be created (a file in its place, or a redirected AppData that's offline), the app didn't start, and picking an icon or "Open logs folder" crashed it.After: the takeover only reads ".exe" where a name ends, so the installed MicSwitch keeps its entry. Changing hotkeys ends any hold, so push-to-talk goes back to muted. The app starts and drops log lines while the folder can't be written, and the icon picker and "Open logs folder" show a message.
How:
AutostartCommand.GetExecutableaccepts ".exe" only before whitespace or the end.MainViewModel.HotkeyRegistrationremembers a held hotkey and releases it when the hotkeys are re-applied.FileLoggerProvider,SelectIconandOpenLogsFoldercatch the folder errors. The test fake for hotkeys now ignores a release that didn't see a press, like the real hook does. Round-3 fuzzers are archived outside the repo; the report has the details.Generated by Claude Code