Repository navigation
refactor: use builder boost factor for gloas block production - #9807
Merged
Merged
Conversation
Contributor
Performance Report鉁旓笍 no performance regression detected Full benchmark results
|
nflaig
commented
Aug 11, 2026
nflaig
commented
Aug 11, 2026
Comment on lines
+899
to
+901
| // Keep a builder bid as fallback unless the circuit breaker is active | ||
| const builderBid = circuitBreakerActive | ||
| ? null |
Member
Author
There was a problem hiding this comment.
unsure if we should still pick a builder bid even if the circuit breaker is active in case local fails, it's not very likely that local payload production fails but having bid as a fallback could be good still, on the other hand, it could also be that builders are attacking the network with large payloads that are slow to process or equivocations, or other attacks, so not selecting builder bids at all might be a safety feature
nflaig
marked this pull request as ready for review
August 11, 2026 16:51
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bc251e502e
鈩癸笍 About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
nflaig
commented
Aug 11, 2026
matthewkeil
self-requested a review
August 12, 2026 16:35
matthewkeil
reviewed
Aug 13, 2026
| ? null | ||
| : chain.executionPayloadBidPool.getBestBid(slot, bidParentBlockHash, parentBlockRootHex); | ||
| // Keep a builder bid as fallback unless the circuit breaker is active | ||
| const builderBid = circuitBreakerActive |
Member
There was a problem hiding this comment.
could easily keep the executiononly and skip the proposal here instead of mucking with the min_bid, right?
Member
Author
There was a problem hiding this comment.
yes, if we wanna keep executiononly, but I wanna get rid of that
Co-authored-by: Matthew Keil <github@mail.matthewkeil.com>
nflaig
commented
Aug 13, 2026
matthewkeil
approved these changes
Aug 13, 2026
matthewkeil
enabled auto-merge (squash)
August 13, 2026 12:24
github-project-automation
Bot
moved this from In Progress
to Done
in Lodestar Team Coordination
Member
|
馃帀 This PR is included in v1.47.0 馃帀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #9595 that removes Lodestar-specific selection modes from Gloas block production and uses
builder_boost_factoras the selection inputethereum/beacon-APIs#630 will move
produceBlockV4to aBuilderConfigrequest body and add builder-API bid routing. That wire-format change is not implemented here. This keepsbuilder_boost_factoras the global Gloas selection control so the same preference can apply to p2p and builder-API bids once that flow is implemented.builder_selectionparameter fromproduceBlockV4--builder.selectionas validator client aliases forbuilder_boost_factorexecutiononlyoption asexecutionalwayspost-Gloas so a viable builder bid can prevent a missed proposal