feat: return 204 when producing payload attestation if there is no block#9589
Open
nflaig wants to merge 2 commits into
Open
feat: return 204 when producing payload attestation if there is no block#9589nflaig wants to merge 2 commits into
nflaig wants to merge 2 commits into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ec90d98b08
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| try { | ||
| const payloadAttestationData = await this.producePayloadAttestationData(slot); | ||
| // No canonical block at slot resolves to `undefined` | ||
| const payloadAttestationData = (await this.api.validator.producePayloadAttestationData({slot})).value(); |
There was a problem hiding this comment.
When the VC is pointed at a beacon node that still returns 404 for “no canonical block at this slot” (the behavior this code handled before, and still plausible while the endpoint semantics are unsettled), calling value() directly makes ApiResponse.value() assert the response is OK and throw. The outer catch then logs Error on PTC routine instead of quietly skipping the payload attestation, reintroducing the noise this change is meant to avoid for mixed-version or non-updated beacon nodes. Keep the 404-as-empty handling alongside the new 204/undefined path.
Useful? React with 👍 / 👎.
Member
Author
There was a problem hiding this comment.
not a concern, this is only relevant for devnets right now
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the producePayloadAttestationData endpoint to return a 204 No Content status with undefined data instead of throwing a 404 Not Found error when no canonical block is found at the specified slot. While this is a solid improvement, the reviewer noted that returning early on a 204 response in the Fastify handler without setting metadata headers will cause client-side parsing errors, as the client expects the Eth-Consensus-Version header. It is recommended to serialize and set these headers before returning.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
nflaig
changed the title
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per ethereum/beacon-APIs#612 (comment)
the spec has not settled yet but to avoid noise in the logs we should use 204 for now. Can always revert back to 404 if that's what we decide to go with on the spec side.