feat: align proposer preferences api with latest spec#9570
Open
nflaig wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request moves the proposer preferences submission and retrieval endpoints from the beacon pool API to the validator API. Specifically, the submitSignedProposerPreferences and getPoolProposerPreferences endpoints have been removed from the beacon pool routes, and a new submitProposerPreferences endpoint has been introduced under the validator routes. The list type size for signed proposer preferences has also been updated to use (MIN_SEED_LOOKAHEAD + 1) * SLOTS_PER_EPOCH, and the event emitter version resolution for proposer preferences now dynamically resolves the fork name based on the proposal slot. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
nflaig
commented
Jun 30, 2026
|
|
||
| /** | ||
| * Get signed proposer preferences from operations pool | ||
| * Retrieves proposer preferences known by the node but not necessarily incorporated into any block. |
Member
Author
There was a problem hiding this comment.
incorporated into any block
what? since when are proposer preferences incorporated into a block? 😂
nflaig
changed the title
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns our implementation with ethereum/beacon-APIs#608
/eth/v1/beacon/pool/proposer_preferences-->/eth/v1/validator/proposer_preferencesGET /eth/v1/beacon/pool/proposer_preferencesendpoint, we can reconsider adding a/lodestarendpoint for this if it would be useful for debugging or propose it to the spec, but for now I don't think it's that useful to have(MIN_SEED_LOOKAHEAD + 1) * SLOTS_PER_EPOCHper specEth-Consensus-Versionheader and eventversionfrom proposal slot