Skip to content

test: make isAttestation handler work with negative tests #9466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nflaig merged 4 commits into from
Jun 6, 2026
+12 −10
Merged

test: make isAttestation handler work with negative tests #9466

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1a66330
fix: make isAttestation handler work with negative tests
markolazic01 Jun 5, 2026
5c29699
Merge branch 'unstable' into fix/is-attestation-handler
markolazic01 Jun 5, 2026
f3c81e7
chore: move test setup out of the try block
markolazic01 Jun 5, 2026
f2900eb
chore: format code
markolazic01 Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions packages/beacon-node/test/spec/presets/fork_choice.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,15 +183,22 @@ const forkChoiceTest =

// attestation step
else if (isAttestation(step)) {
logger.debug(`Step ${i}/${stepsLen} attestation`, {root: step.attestation, valid: Boolean(step.valid)});
const isValid = Boolean(step.valid ?? true);
logger.debug(`Step ${i}/${stepsLen} attestation`, {root: step.attestation, valid: isValid});
const attestation = testcase.attestations.get(step.attestation);
if (!attestation) throw Error(`No attestation ${step.attestation}`);
const headState = chain.getHeadState() as BeaconStateView;
const attDataRootHex = toHexString(sszTypesFor(fork).AttestationData.hashTreeRoot(attestation.data));
chain.forkChoice.onAttestation(
headState.cachedState.epochCtx.getIndexedAttestation(ForkSeq[fork], attestation),
attDataRootHex
const indexedAttestation = headState.cachedState.epochCtx.getIndexedAttestation(
ForkSeq[fork],
attestation
);
try {
chain.forkChoice.onAttestation(indexedAttestation, attDataRootHex);
if (!isValid) throw Error("Expect error since this is a negative test");
} catch (e) {
if (isValid || (e as Error).message === "Expect error since this is a negative test") throw e;
}
}

// attester slashing step
Expand Down Expand Up @@ -738,12 +745,7 @@ const forkChoiceTest =
// unconditionally. Only the altair vectors exercise the changed condition (other forks pass).
name.endsWith("altair/fork_choice/on_block/pyspec_tests/justified_update_always_if_better") ||
name.endsWith("altair/fork_choice/on_block/pyspec_tests/justified_update_not_realized_finality") ||
name.endsWith("altair/fork_choice/get_head/pyspec_tests/voting_source_beyond_two_epoch") ||
// TODO GLOAS: re-enable after the validate_on_attestation payload-status updates
// (consensus-specs #5275) are implemented. New gloas on_attestation vectors in v1.7.0-alpha.9.
name.endsWith("validate_on_attestation_beacon_root_payload_check") ||
name.endsWith("validate_on_attestation_payload_invalid_index") ||
name.endsWith("validate_on_attestation_same_slot_full_vote_rejected"),
name.endsWith("altair/fork_choice/get_head/pyspec_tests/voting_source_beyond_two_epoch"),
},
};
};
Expand Down
Loading