Skip to content

fix: publish only subscribed columns from reconstruction #9464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nflaig merged 1 commit into from
Jun 5, 2026
Merged

fix: publish only subscribed columns from reconstruction #9464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 17 additions & 12 deletions packages/beacon-node/src/util/dataColumns.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,15 +470,17 @@ export async function recoverDataColumnSidecars(
return DataColumnReconstructionCode.SuccessLate;
}

// Once the node obtains a column through reconstruction,
// the node MUST expose the new column as if it had received it over the network.
// If the node is subscribed to the subnet corresponding to the column,
// it MUST send the reconstructed DataColumnSidecar to its topic mesh neighbors.
// If instead the node is not subscribed to the corresponding subnet,
// it SHOULD still expose the availability of the DataColumnSidecar as part of the gossip emission process.
// After exposing the reconstructed DataColumnSidecar to the network,
// the node MAY delete the DataColumnSidecar if it is not part of the node's custody requirement.
const sidecarsToPublish = [];
// Per consensus-specs PR #4657, only publish reconstructed columns the node is
// subscribed to (custody + sampling). Eagerly cross-seeding non-subscribed
// columns floods the network with duplicates because the sender has no
// visibility into which peers already saw the message via the topic mesh.
// This matches the getBlobsV2 path in `getDataColumnSidecarsFromExecution` and
// aligns with Lighthouse/Prysm. Capture missing sampled indices before adding
// any reconstructed columns so they are not filtered out by the subsequent
// `addColumn` calls.
const missingSampledColumns = new Set(input.getMissingSampledColumnMeta().missing);
const sidecarsReconstructed: DataColumnSidecar[] = [];
const sidecarsToPublish: DataColumnSidecar[] = [];
for (const columnSidecar of fullSidecars) {
if (!input.hasColumn(columnSidecar.index)) {
if (input instanceof PayloadEnvelopeInput) {
Expand All @@ -501,11 +503,14 @@ export async function recoverDataColumnSidecars(
source: BlockInputSource.recovery,
});
}
sidecarsToPublish.push(columnSidecar);
sidecarsReconstructed.push(columnSidecar);
if (missingSampledColumns.has(columnSidecar.index)) {
sidecarsToPublish.push(columnSidecar);
}
}
}
metrics?.peerDas.reconstructedColumns.inc(sidecarsToPublish.length);
metrics?.dataColumns.bySource.inc({source: BlockInputSource.recovery}, sidecarsToPublish.length);
metrics?.peerDas.reconstructedColumns.inc(sidecarsReconstructed.length);
metrics?.dataColumns.bySource.inc({source: BlockInputSource.recovery}, sidecarsReconstructed.length);
emitter.emit(ChainEvent.publishDataColumns, sidecarsToPublish);
// TODO: Can we record dataColumns.sentPeersPerSubnet metric somehow
return DataColumnReconstructionCode.SuccessResolved;
Expand Down
Loading