chore: remove old deposit mechanism in fulu#9459
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements changes to handle the removal of the Eth1 bridge deposit mechanism starting from the Fulu fork. Specifically, it restricts setting depositRequestsStartIndex and checking pending Eth1 bridge deposits to pre-Fulu forks, and updates getEth1DepositCount to return 0 for Fulu and later forks. A corresponding unit test has been added to verify this behavior. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Contributor
Performance Report🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
3 tasks
ensi321
reviewed
Jun 3, 2026
ensi321
left a comment
ensi321
left a comment
Member
There was a problem hiding this comment.
looks good to me. Minor comments about style
nflaig
changed the title
lodekeeper
approved these changes
Jun 3, 2026
lodekeeper
left a comment
lodekeeper
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Reviewed against v1.7.0-alpha.9 Fulu spec (specs/fulu/beacon-chain.md):
processDepositRequest.ts: gate matches Fulu's modifiedprocess_deposit_request, which only appends topending_depositsand no longer touchesdeposit_requests_start_index.processPendingDeposits.ts: gate matches the removal of the "no requests before bridge deposits" condition post-Fulu (since bridge deposits are gone).util/deposit.ts:getEth1DepositCount → 0for Fulu+ is the right single-source change. The existingbody.deposits.length !== maxDepositscheck inprocessOperationsthen enforcesassert len(body.deposits) == 0from the Fulu spec, and the unchangedfor (const deposit of body.deposits) processDeposit(...)loop is naturally a no-op once that assert has passed. Cleaner than a separate Fulu branch.- Iterator-skip removal +
spec-tests-version.jsonbump look right;v1.7.0-alpha.10release tarball isn't published on consensus-specs yet (current CI download step 404s), but the alpha.10 nightly artifacts from consensus-specs run 26884230978 — which are the exact build that will become alpha.10 — pass on this branch per @nflaig's local run. Once the release publishes, the existing CI cache step will pick it up cleanly. - Unit test covers the new Fulu branch of
getEth1DepositCountdirectly.
Closed my parallel attempt (#9458) — this is strictly cleaner.
wemeetagain
approved these changes
Jun 4, 2026
Member
|
🎉 This PR is included in v1.44.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see ethereum/consensus-specs#4704, closes #9448