feat: implement publishExecutionPayloadBid api#9392
Closed
twoeths wants to merge 1 commit into
Closed
Conversation
Member
Author
|
this is already part of #9289 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements the publishExecutionPayloadBid endpoint, enabling the beacon node to broadcast signed execution payload bids to the network. The changes include updating the API definitions, adding validation logic, and integrating the gossip network publishing functionality. The review feedback suggests improving observability by logging the number of peers reached during publication and using the more idiomatic sszTypesFor(fork) helper for persisting invalid SSZ values to ensure future-proof fork compatibility.
Comment on lines
+859
to
+864
| await network.publishExecutionPayloadBid(signedExecutionPayloadBid); | ||
|
|
||
| chain.emitter.emit(routes.events.EventType.executionPayloadBid, { | ||
| version: fork, | ||
| data: signedExecutionPayloadBid, | ||
| }); |
Contributor
There was a problem hiding this comment.
It is recommended to log the number of peers the bid was successfully published to, consistent with the implementation of publishExecutionPayloadEnvelope. This improves observability and helps in debugging network propagation issues.
const sentPeers = await network.publishExecutionPayloadBid(signedExecutionPayloadBid);
chain.emitter.emit(routes.events.EventType.executionPayloadBid, {
version: fork,
data: signedExecutionPayloadBid,
});
chain.logger.info("Published execution payload bid", {...logCtx, sentPeers});
Comment on lines
+871
to
+873
| if (e instanceof ExecutionPayloadBidError && e.action === GossipAction.REJECT) { | ||
| chain.persistInvalidSszValue(ssz.gloas.SignedExecutionPayloadBid, signedExecutionPayloadBid, "api_reject"); | ||
| } |
Contributor
There was a problem hiding this comment.
Using sszTypesFor(fork).SignedExecutionPayloadBid is more idiomatic in Lodestar and ensures that the correct fork-specific type is used for persistence, especially as the protocol evolves in future forks.
Suggested change
| if (e instanceof ExecutionPayloadBidError && e.action === GossipAction.REJECT) { | |
| chain.persistInvalidSszValue(ssz.gloas.SignedExecutionPayloadBid, signedExecutionPayloadBid, "api_reject"); | |
| } | |
| if (e instanceof ExecutionPayloadBidError && e.action === GossipAction.REJECT) { | |
| chain.persistInvalidSszValue(sszTypesFor(fork).SignedExecutionPayloadBid, signedExecutionPayloadBid, "api_reject"); | |
| } |
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Implement the
publishExecutionPayloadBidBeacon API endpoint so external builders can submit signed bids without running their own beacon node.Closes a
TODO GLOASgap in the oapi conformance test.Description
POST /eth/v1/beacon/execution_payload_bidroute + handler, mirroringpublishExecutionPayloadEnvelope.network.publishExecutionPayloadBidsymmetric topublishProposerPreferences.validateApiExecutionPayloadBid,ExecutionPayloadBidPool, error types, gossip topic, metrics, and SSE event.AI Assistance Disclosure
Used Claude Code.