feat: only give proposer boost to canonical proposer#9313
Merged
Conversation
Per consensus-specs PR #4807, `update_proposer_boost_root` now only sets `proposer_boost_root` when the imported block's `proposer_index` matches the head state's expected proposer for the slot, so a divergent proposer shuffling on a non-canonical fork cannot nullify proposer boost. `onBlock` gains an `expectedProposerIndex` argument; `importBlock` resolves it via `headState.currentProposers` / `nextProposers` (O(1), backed by `state.proposerLookahead` post-fulu) — same fast path used by the proposer-preferences gossip validator. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the onBlock method in the fork choice implementation to include an expectedProposerIndex parameter, which is used to restrict proposer boost to blocks from the expected proposer. Changes include updating the IForkChoice interface, the importBlock logic, and relevant tests. A review comment suggests refactoring the logic for determining the expected proposer index to avoid duplication between the main code and test utilities.
Comment on lines
+120
to
+126
| let expectedProposerIndex: number | null = null; | ||
| const headState = this.getHeadState(); | ||
| if (headState.epoch === blockEpoch) { | ||
| expectedProposerIndex = headState.currentProposers[blockSlot % SLOTS_PER_EPOCH]; | ||
| } else if (headState.epoch + 1 === blockEpoch) { | ||
| expectedProposerIndex = headState.nextProposers[blockSlot % SLOTS_PER_EPOCH]; | ||
| } |
Contributor
There was a problem hiding this comment.
The logic for determining the expected proposer index from the head state is duplicated in packages/beacon-node/test/spec/utils/gossipValidation.ts. Consider encapsulating this logic into a shared helper function or using the existing state.getBeaconProposer(slot) method with appropriate error handling. This would improve maintainability and ensure consistency across the codebase when resolving proposers from a given state.
Contributor
Performance Report🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
The retroactive proposer-boost spec change from v1.7.0-alpha.1 is now implemented, so `voting_source_beyond_two_epoch`, `justified_update_always_if_better`, and `justified_update_not_realized_finality` pass across all forks (altair → gloas, 21 fixtures total). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
twoeths
reviewed
May 1, 2026
twoeths
reviewed
May 1, 2026
twoeths
reviewed
May 8, 2026
twoeths
left a comment
twoeths
left a comment
Member
There was a problem hiding this comment.
may want something like
getBeaconProposerOrNull(slot: Slot): ValidatorIndex | null {
// or just call the current getBeaconProposer() and catch return null
const epoch = computeEpochAtSlot(slot);
if (epoch === this.currentShuffling.epoch) return this.proposers[slot % SLOTS_PER_EPOCH];
if (epoch === this.nextEpoch) return this.getBeaconProposersNextEpoch()[slot % SLOTS_PER_EPOCH];
return null;
}and use that everywhere
looks good to me other than that
nflaig
reviewed
May 28, 2026
| this.proposerBoostRoot === null | ||
| this.proposerBoostRoot === null && | ||
| expectedProposerIndex !== null && | ||
| block.proposerIndex === expectedProposerIndex |
Member
There was a problem hiding this comment.
this will be changed in ethereum/consensus-specs#5306 to use dependent root instead
Member
|
🎉 This PR is included in v1.44.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #9231