Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 637d7ecec2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| builder_boost_factor: builderBoostFactor.toString(), | ||
| include_payload: includePayload, | ||
| }, | ||
| body: ssz.gloas.SignedExecutionPayloadBid.toJson(signedExecutionPayloadBid), |
There was a problem hiding this comment.
When slot is on Heze, these hard-coded Gloas codecs omit or reject Heze's required inclusionListBits field, which is added to SignedExecutionPayloadBid in packages/types/src/heze/sszTypes.ts:43-57. Both the JSON and SSZ request paths therefore cannot transport a valid Heze bid, even though this endpoint accepts every post-Gloas fork and its response codec already dispatches by version. Resolve the fork from the slot or version header and use its SignedExecutionPayloadBid codec for serialization and parsing.
AGENTS.md reference: AGENTS.md:L202-L210
Useful? React with 👍 / 👎.
nflaig
force-pushed
the
nflaig/produce-block-v4-with-bid
branch
from
September 12, 2026 20:35
637d7ec to
f5d3c08
Compare
nflaig
changed the base branch from
unstable
to
nflaig/extract-produce-gloas-block
September 12, 2026 20:35
nflaig
marked this pull request as draft
September 12, 2026 20:39
Contributor
Performance Report🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
This was referenced Sep 12, 2026
Open
**Motivation** When a supplied bid fails validation, `produceBlockV4WithBid` falls back exclusively to local payload production, even if a matching P2P bid is available. A slow local build can therefore delay the proposal unnecessarily. In one case observed on plataberget, a produceBlockV4WithBid request arrived 603 ms into the slot and took 3.483 seconds to return a local block due to a slow Engine getPayloadV6 API call, resulting in an orphaned block. A matching P2P bid was already available. If its beacon block had been ready by the existing two-second slot cutoff, this fallback could have returned after approximately 1.397 seconds, about 2.086 seconds sooner. **Description** Consider the best matching P2P bid immediately after a supplied bid fails validation, while local payload production continues in parallel. Apply the existing minimum bid and boost rules to select between the two blocks. A ready P2P block can be returned at the existing cutoff without waiting for slow local production. Valid supplied bids and builder circuit-breaker behavior remain unchanged. Add tests covering parent matching, local payload preference, immediate fallback, and returning a P2P block while local production is pending. Validation: all 46 targeted block-production tests pass, along with lint, beacon-node type-checking, and the build. **AI Assistance Disclosure** - [x] External Contributors: I have read the [contributor guidelines](https://github.com/ChainSafe/lodestar/blob/unstable/CONTRIBUTING.md#ai-assistance-notice) and disclosed my usage of AI below. This PR was written primarily by OpenAI Codex - GPT-6, including the implementation and tests.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements ethereum/beacon-APIs#627. A validator client that selects the execution payload bid itself, from builders it queries directly or from the
execution_payload_bidSSE topic, can ask any beacon node to build a block with it. The beacon node only weighs the supplied bid against its local payload, an invalid bid or an active circuit breaker falls back to the local payload.POST /eth/v4/validator/blocks/{slot}/with_bid, the signed bid as body,builder_boost_factorandinclude_payloadas query paramsproduceBlockV4, a supplied bid takes the place of builder API and p2p bidsbeacon_block_production_supplied_bids_discarded_totalBuilds on #10073.