Repository navigation
fix: align gloas external signer requests with remote signing api - #10071
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
nflaig
marked this pull request as draft
September 12, 2026 16:04
nflaig
marked this pull request as ready for review
September 12, 2026 16:10
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #10071 +/- ##
=========================================
Coverage 52.78% 52.78%
=========================================
Files 848 848
Lines 58976 58976
Branches 4345 4345
=========================================
Hits 31128 31128
Misses 27791 27791
Partials 57 57 🚀 New features to boost your workflow:
|
Contributor
Performance Report🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
4 tasks
twoeths
approved these changes
Sep 14, 2026
matthewkeil
moved this from In Progress
to Awaiting Author
in Lodestar Team Coordination
github-project-automation
Bot
moved this from Awaiting Author
to Done
in Lodestar Team Coordination
Member
|
🎉 This PR is included in v1.49.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the external signer client with the Glamsterdam additions to the remote signing api (ethereum/remote-signing-api#28). All new gloas payloads are
version-wrapped likeBLOCK_V2andAGGREGATE_AND_PROOF_V2, and the PTC signing type is named after the message the validator produces, consistent withATTESTATIONandSYNC_COMMITTEE_MESSAGEwhich also carry only the signed data.PAYLOAD_ATTESTATIONtoPAYLOAD_ATTESTATION_MESSAGE, body keypayload_attestation_messageexecution_payload_envelope,payload_attestation_message,proposer_preferencesandbuilder_request_authin{version, data}, version is the fork at the message slotThe same request shapes are implemented in Consensys-Incorporated/web3signer#1192.