Handle orphaned execution payloads

[nflaig]

We need to make sure to properly handle orphaned execution payloads. There are two places I can think of right now:

• range sync when we fetch block/envelopes by range, we need to skip trying to sync those even if a peer serves them and downscore the peer
• archiving of finalized data, we need to avoid storing them in archive db, can have a separate storage for orphaned execution payloads, we have the same for blocks

We need to check with the beacon block if it's building on full or empty. The parent hash in the bid from block N is equal to the block hash in the bid of N-1? If yes it's full and the Payload of N-1 is included. If it's not then empty and the Payload is orphaned.

[nflaig]

same likely also applies for data columns by root/range although I haven't seen any discussion on that yet since it was not tested as part of epbs-devnet-0

[dicethedev]

We need to make sure to properly handle orphaned execution payloads. There are two places I can think of right now:

• range sync when we fetch block/envelopes by range, we need to skip trying to sync those even if a peer serves them and downscore the peer
• archiving of finalized data, we need to avoid storing them in archive db, can have a separate storage for orphaned execution payloads, we have the same for blocks

We need to check with the beacon block if it's building on full or empty. The parent hash in the bid from block N is equal to the block hash in the bid of N-1? If yes it's full and the Payload of N-1 is included. If it's not then empty and the Payload is orphaned.

Should orphaned payloads be written anywhere (for debugging/analytics) or purely discarded?

[nflaig]

Should orphaned payloads be written anywhere (for debugging/analytics) or purely discarded?

we should add an option to store them similar to orphaned blocks, but this is something to look at later

[dicethedev]

Should orphaned payloads be written anywhere (for debugging/analytics) or purely discarded?

we should add an option to store them similar to orphaned blocks, but this is something to look at later

Can you help identify the key files that should include this implementation for orphaned execution payloads? I’ve reviewed the attached PR, but I’d like to be certain before moving forward.

[nflaig]

Can you help identify the key files that should include this implementation for orphaned execution payloads? I’ve reviewed the attached PR, but I’d like to be certain before moving forward.

Like I said above, this is something to look at later as there are a lot of moving pieces right now, you can check how we currently store orphaned blocks and come up with an implementation for payloads, but that PR might need to be reworked afterwards