Skip to content

Map VSPC 9.3 to API 3.7 so detection stops resolving it to 3.6.2 - #22

Merged
JonahMMay merged 1 commit into
mainfrom
fix/detect-9.3
Aug 14, 2026
Merged

JonahMMay merged 1 commit into
mainfrom
fix/detect-9.3

Conversation

@JonahMMay

Copy link
Copy Markdown
Member

3.7 landed in VERSION_TO_PACKAGE without a matching entry in SERVER_TO_API_VERSION, which the two pull requests could not have caught individually — one added the package, the other added the mapping table, and neither was wrong on its own.

The failure was silent rather than loud. A console newer than everything mapped deliberately falls back to the newest mapped version, so a 9.3 console (9.3.0.35057) detected as 3.6.2 and spoke the older API against a server that serves 3.7. Nothing raised; callers just quietly lost the 47 operations 3.7 adds.

Adds the test that would have caught it. The existing check only asserted that every mapped API version is packaged, which is the direction that fails loudly anyway — a mapping to a missing package raises on import. The reverse, a packaged version no console maps to, is the one that goes unnoticed, so it is now asserted directly.

3.7 landed in VERSION_TO_PACKAGE without a matching entry in SERVER_TO_API_VERSION,
which the two pull requests could not have caught individually — one added the package,
the other added the mapping table, and neither was wrong on its own.

The failure was silent rather than loud. A console newer than everything mapped
deliberately falls back to the newest mapped version, so a 9.3 console (9.3.0.35057)
detected as 3.6.2 and spoke the older API against a server that serves 3.7. Nothing
raised; callers just quietly lost the 47 operations 3.7 adds.

Adds the test that would have caught it. The existing check only asserted that every
mapped API version is packaged, which is the direction that fails loudly anyway — a
mapping to a missing package raises on import. The reverse, a packaged version no
console maps to, is the one that goes unnoticed, so it is now asserted directly.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@JonahMMay
JonahMMay merged commit bb5a4ff into main Aug 14, 2026
2 checks passed
@JonahMMay
JonahMMay deleted the fix/detect-9.3 branch August 14, 2026 17:59
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@JonahMMay, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 25 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 034ad12e-c33d-448f-b415-d6ee6b152479

📥 Commits

Reviewing files that changed from the base of the PR and between 6005560 and 69737ad.

📒 Files selected for processing (2)
  • tests/test_discovery.py
  • veeam_spc/discovery.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant