Repository navigation
feat: conformance/drift verdict artifact in Rust and Go - #60
Merged
Merged
Conversation
added 2 commits
October 18, 2026 23:41
… with a differential corpus --- [signing-metadata] key = cic-my-sign-key signature = vault:v1:MEYCIQCaJU+Ywl9cqHVRvUUg1TydmrdkSvH8KC/yd+DagIipGQIhAJi+Pw1e3ul5M6wrOBh4PWCd3MDn/VNUW8tiTLxBt+Ec hash-algorithm = sha256 digest = F0YbnUHqn8NXdvaZXkmXMGhp/AzNSHaNZsRM7W2FdCg= [certificate] -----BEGIN CERTIFICATE----- MIICBjCCAaygAwIBAgIUSnRMR6RPnEbg296XWPOqq/u5PCwwCgYIKoZIzj0EAwIw QzELMAkGA1UEBhMCSFUxGTAXBgNVBAoMEENlbnRyYWxJbmZyYUNvcmUxGTAXBgNV BAMMEENJQyBEZXZlbG9wZXIgQ0EwHhcNMjYwMzIwMTMyMjU5WhcNMjYxMjMxMTMy MjU5WjBFMQswCQYDVQQGEwJIVTEZMBcGA1UECgwQQ2VudHJhbEluZnJhQ29yZTEb MBkGA1UEAwwSR2Fib3IgWm9sdGFuIFNpbmtvMFkwEwYHKoZIzj0CAQYIKoZIzj0D AQcDQgAEIG2CVmTfmLB9pLLclj7YmP2eedAjklpy4LGrU2ijoiy6Xqpuybv7OgJe i+ez31s65NEV8+X/ByeX1cstR988z6N8MHowCQYDVR0TBAIwADAdBgNVHQ4EFgQU yZN6AIX/TNnIJ9GwAa/NRN3ujHAwHwYDVR0jBBgwFoAUXn6CHYzPUqU4JVP8g+OS WeDYjhcwDgYDVR0PAQH/BAQDAgeAMB0GA1UdJQQWMBQGCCsGAQUFBwMCBggrBgEF BQcDBDAKBggqhkjOPQQDAgNIADBFAiEA+bFzXRoJ4PCQbhAAtpkcMjt0vNj5rEW0 lOMBGDNyaWkCIB1vmM7PcZzv/c9bIrxF5kqv6QXomouhByUfeNUTbpKW -----END CERTIFICATE-----
…ths the plan cannot produce, document the low-level builder's limits --- [signing-metadata] key = cic-my-sign-key signature = vault:v1:MEQCIGZSBvHYHFyFSWbL8NRiiQVezQ31+1bSXYK4ETmdO8ciAiAEA2x9nFCGnk3n05DLh8NG27zGDx6I1T6igM98gUR1oQ== hash-algorithm = sha256 digest = /7LnYrURshnUbEAx/j8JXxB4GWNcQCkpzRdqMyTJZVc= [certificate] -----BEGIN CERTIFICATE----- MIICBjCCAaygAwIBAgIUSnRMR6RPnEbg296XWPOqq/u5PCwwCgYIKoZIzj0EAwIw QzELMAkGA1UEBhMCSFUxGTAXBgNVBAoMEENlbnRyYWxJbmZyYUNvcmUxGTAXBgNV BAMMEENJQyBEZXZlbG9wZXIgQ0EwHhcNMjYwMzIwMTMyMjU5WhcNMjYxMjMxMTMy MjU5WjBFMQswCQYDVQQGEwJIVTEZMBcGA1UECgwQQ2VudHJhbEluZnJhQ29yZTEb MBkGA1UEAwwSR2Fib3IgWm9sdGFuIFNpbmtvMFkwEwYHKoZIzj0CAQYIKoZIzj0D AQcDQgAEIG2CVmTfmLB9pLLclj7YmP2eedAjklpy4LGrU2ijoiy6Xqpuybv7OgJe i+ez31s65NEV8+X/ByeX1cstR988z6N8MHowCQYDVR0TBAIwADAdBgNVHQ4EFgQU yZN6AIX/TNnIJ9GwAa/NRN3ujHAwHwYDVR0jBBgwFoAUXn6CHYzPUqU4JVP8g+OS WeDYjhcwDgYDVR0PAQH/BAQDAgeAMB0GA1UdJQQWMBQGCCsGAQUFBwMCBggrBgEF BQcDBDAKBggqhkjOPQQDAgNIADBFAiEA+bFzXRoJ4PCQbhAAtpkcMjt0vNj5rEW0 lOMBGDNyaWkCIB1vmM7PcZzv/c9bIrxF5kqv6QXomouhByUfeNUTbpKW -----END CERTIFICATE-----
Member
Author
|
Both counterexamples reproduced on Reproduction on
Change
New counterexample tests (Rust and Go, each)
Local results: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the conformance/drift verdict artifact of
docs/VERDICT-SCHEMA.mdin Rust and Go. Scope is kept: Parse/Normalize/Resolve/Validate stay the environment's job; D-018 semantics, the materialization receipt and the Relay enforcement boundary are untouched.What it adds
engine/src/verdict.rs:ConformanceVerdictwith all five required fields (verdict_schema_version: 1,object,fields,conformance_plan_digest,observation_digest),build_verdict,verdict_value,verdict_canonical_bytes.go/verdict: the Go peer (Build,Value,CanonicalBytes), plus an exportedplan.Aggregate(Rust'saggregateis already public).E_INCONSISTENT_VERDICT/R-VERDICT-CONSISTENT: the builder refuses an evaluate result that cannot be one (classified paths and consumed evidence that do not match one to one; a planned scalar missing fromfields; anobjectthat does not follow fromfields). A realevaluateresult always passes.conformance/differential/verdict/: 7 artifact vectors (theplan/inputs) and 4 refusal vectors (tamperedits), docs updated (VERDICT-SCHEMA.mdstatus section, READMEs).Where the values come from
fields:evaluate's ownfields, so exactly the evaluated paths.conformance_plan_digest/observation_digest(and Go peers), called, not recomputed; a test in each language pins this. Themulti_key_collection_identityvector's plan digest is byte-identical to the pin of the existingdigest/plan_digest_with_collectionvector.Tests
verdict.rs,verdict_vectorsandverdict_vectors_detect_deliberate_divergenceinengine/tests/differential.rs.TestDifferentialVerdictVectors,TestDifferentialVerdictVectorsDetectDeliberateDivergence.object/fieldsas the same-namedplan/pin. Negative: 4 refusals with the same code and path in both languages. Divergence: 8 deliberate divergences (version bump, changed object, changed/dropped/added field, altered or swapped digests) on each of the 7 vectors, 56 cases per language, each must be caught.Local results
cargo fmt --checkclean,cargo clippy --workspace --all-targets -- -D warningsclean,cargo test --workspaceand--releaseall passing (71 lib, 7 differential, 11 properties, 8 value invariants, 3 conformance, 4 cli);gofmt,go vet,go test -race ./...all passing (7 packages).Not done, as before
Signing the artifact and an intent-digest field stay "not decided" in the schema.
Not to be merged without review.