ci: fire release workflow once per merge#82
Merged
Conversation
The release workflow had both a push:[main] and a pull_request:closed trigger, so every PR merge to main fired it twice. Both runs raced to create the same version tag — one succeeded, the other failed noisily with "tag already exists". A single push:[main] trigger already covers both PR merges and direct pushes, so drop the redundant pull_request trigger and the now-trivial event-type guard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Create Release" workflow had both a
push: [main]and apull_request: closed → [main]trigger. Every PR merge tomaintherefore fired it twice — both runs raced to create the same version tag, one succeeding and the other failing withtag already exists(observed on the 0.0.41 release).A single
push: [main]trigger already covers both PR merges and direct pushes. This drops the redundantpull_requesttrigger and the now-trivialif: github.event_name == 'push' || ...guard.Effect
One workflow run per release, no spurious red run. No change to release behaviour otherwise.
Note
Pure CI cleanup — no version bump. Ships with the next release.
Test plan
mainproduces exactly one "Create Release" run, succeeding