Conversation
- Add version.json creation steps to Quick-Start, Your-First-App, and
Project-Structure guides; explain getAppCode/Name/Version() getters
and the Monolog channel / storage path side-effect of 'code'
- Fix all config-{env}.json examples to use correct top-level keys
(application.global.*, logger.* instead of app.*, logging.*)
- Remove redundant "version" key from config.json tutorial example
- Add \n to line_format in all logger file-driver examples and document
the Linux/Docker line-ending requirement in Configuration.md and the
Getting-Started guides
docs: document version.json setup and fix config-{env}.json examples
Redis get() returned false for any integer stored via set() because Predis always returns strings, so the is_int() fast-path never matched and the raw integer was passed to unserialize(). get() now detects raw integers via filter_var() and uses an explicit null check so falsy stored values are no longer mistaken for cache misses. Adds testValueRoundTrip data-provider regression tests to the Redis and APCu adapter suites. Bumps version to 0.0.41.
The @dataProvider docblock annotation is not recognized under PHPUnit 12 (PHP 8.3/8.4 CI matrix), causing testValueRoundTrip to run with zero arguments and error. The PHP 8 attribute form works across all PHPUnit versions in the matrix.
The master branch was retired on GitHub; the release workflow still triggered on master, so release automation had been dead since ~0.0.34 (missing tags 0.0.36-0.0.38). Repoint release.yml push/pull_request triggers to main, and drop the `v` tag prefix to match current tag practice (0.0.39, 0.0.40 are unprefixed). Also update Contributor-Guide docs that still referenced master.
ci: retire master branch — point release workflow and docs at main
fix(cache): round-trip integer values in Redis adapter (#78)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promotes
developtomainfor the 0.0.41 release.Included changes:
get()detects raw integers viafilter_var()and uses an explicit null miss-check so falsy stored values (0,'',false,'0') are no longer treated as cache misses. AddstestValueRoundTripdata-provider regression tests to the Redis and APCu suites.masterbranch tomain, and thevtag prefix dropped to match current tag practice (0.0.39,0.0.40). Contributor-Guide docs updated.Release
Version 0.0.40 → 0.0.41. See
CHANGELOG.mdfor the 0.0.41 entry.Once merged, the push to
maintriggers the "Create Release" workflow, which auto-creates the0.0.41tag and GitHub Release.Test plan
0.0.41