ci: run template integrity on pull requests only - #12
Merged
Conversation
The main ruleset requires a pull request and requires this check, so a run on the merge commit repeats a check that already passed. workflow_dispatch keeps a manual re-run available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
mainruleset now requires a pull request and requires theintegritycheck, so thepush: branches: [main]trigger only re-ran a check that had already passed on the PR head. Every merge burned two runs instead of one.workflow_dispatchreplaces it, so the check can still be re-run by hand without opening a PR.Deliberately not applied to
.github/workflows/examples/ci.yml.example:deploy.yml.examplefires onworkflow_runof CI completing onmain, so removing CI's push-to-main trigger would mean a consumer's deploy never fires.Test plan
pull_requestandworkflow_dispatch.0 problem(s)locally.git diff --checkclean.