Merged
Conversation
…gingFace embedding providers
…fetcher to CatalogEntry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ Issue Number
📝 요약(Summary)
QuestionGate→HybridRetriever→TableSuitabilityEvaluator→QuestionProfiler→ContextEnricher→SQLGenerator→SQLExecutor7단계로 구성된
EnrichedNL2SQL풀 파이프라인을 구현한다.engine/,utils/llm/graph_utils/,utils/llm/vectordb/등 LangChain·LangGraph 기반 레거시 모듈을삭제하고 CLI 및 Streamlit UI를 v2 플로우 기반으로 교체한다.
💬 To Reviewers (선택)
flows/enriched_nl2sql.py):gate_enabled=False로QuestionGate를 선택적으로 비활성화할 수 있습니다. Gate 판단 기준(LLM 프롬프트)이 실제 도메인에 적합한지
검토 부탁드립니다. (
components/gate/prompts/question_gate.md)chatbot_tool.search_database_tables임시 수정 (utils/llm/tools/chatbot_tool.py): 삭제된utils/llm/retrieval.py의존성 제거를 위해KeywordRetriever + DataHubCatalogLoader로 교체했으나,시맨틱 검색 대비 정확도가 낮아 완전한 대체는 아닙니다. 추후 LangGraph 기반
chatbot.py전체를 v2 Agent모드로 교체할 예정이므로 현재는 임시 구현으로 유지합니다.
engine/,utils/llm/graph_utils/,utils/llm/output_schema/,utils/llm/vectordb/,utils/llm/chains.py,utils/llm/retrieval.py,prompt/디렉터리가 모두삭제됩니다. 삭제 전 의존 관계 확인 부탁드립니다.
PR Checklist
ContextEnricher, EnrichedNL2SQL 각 컴포넌트 단위 테스트)
pytest tests/— 145 passed, 6 skipped)__init__.py업데이트 (EnrichedNL2SQL, 신규 LLM/Embedding 프로바이더 export)utils/llm/vectordb/삭제,chatbot_tool.py임포트 교체)docs/production_test_guide.md)reference) How to Code Review