Skip to content

Conversation

@Berend27
Copy link

I created a confirmation dialog to be shown before deleting. This is for the ticket IDE-262.

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@ratschillerp ratschillerp added the Active Member Tickets that are assigned to members that are still currently active label Jan 12, 2026
Copy link
Contributor

@Frajhamster Frajhamster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are existing tests which need to be updated, such as:

  • Catroid\catroid\src\androidTest\java\org\catrobat\catroid\uiespresso\ui\fragment\DeleteLookTest.java
  • Catroid\catroid\src\androidTest\java\org\catrobat\catroid\uiespresso\ui\fragment\DeleteSoundTest.java

And maybe even more, which are affected by your changes, please test it locally and if they fail, update the tests.

@sonarqubecloud
Copy link

Copy link
Contributor

@Frajhamster Frajhamster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.
Please also squash your commits into one, by using "git rebase", you can check how to do this by googling or consulting the almighty AI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Active Member Tickets that are assigned to members that are still currently active

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants