Claude/multitransbender web deploy sue1ue - #2
Merged
Conversation
Replaces the mockup's gold accent with azure. Gold sat in the same hue family as several faceplates (VULTURE's cream, SA2RATE's sand, M-A-S's amber), so selected chrome competed with the hardware it framed; a cool accent separates app from device and stays legible against every faceplate. Four chrome themes per prd.md 3.4 (was two): Studio Dark, Studio Light, Midnight, Graphite. Faceplate palettes stay theme-independent by design. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018fcuaJJNPpDCeczXCh9zBP
… and Windows The JUCE code had never been through a compiler. Getting it there found four real defects, none of which the TypeScript suite could have caught because the two engines are separate code: - CMake declared only CXX, so generate failed on a missing CMAKE_C_COMPILE_OBJECT. JUCE compiles C (and Objective-C++ on Apple). - juce::dsp::IIR::Filter owns a HeapBlock and is non-copyable, so the std::vector::assign calls in BandState and the processor could not compile. Replaced with fixed std::array members, which also keeps the audio thread away from an allocator. - Every band pushed into one shared DelayLine, so each band read back a mixture of its neighbours. Attack-down moved crest factor the wrong way by 2.4 dB. Each band now has its own line. - The real-time engine had the same unaligned-control-signal bug the offline engine had: the differential detector peaks after the onset, so a cut missed the peak. Added a causal sliding-window extremum (monotonic deque, no allocation) and drove the BALANCED lookahead from the slowest band's attack time instead of a fixed 64 samples. The plugin also still carried the six invented devices from before the spec arrived. Replaced with the ten TRANSBAND engines, numerically matching src/dsp/devices.ts, and moved attack/sustain to real dB (+-15 / +-24) per prd.md 3.1 so automation lanes read in dB. Adds plugin/tests/EngineSmokeTest.cpp — 17 checks driving the real AudioProcessor — and a GitHub Actions workflow building VST3, Audio Unit and Standalone for macOS universal, Windows x64 and Linux x64. The workflow runs the smoke test on each platform before packaging, so a red run ships nothing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018fcuaJJNPpDCeczXCh9zBP
The plugin page now links to CI-built releases (macOS universal VST3/AU/ Standalone, Windows x64 VST3/Standalone, Linux x64 VST3/Standalone) rather than to a source archive, and states plainly that the builds are unsigned and what that means at first launch. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018fcuaJJNPpDCeczXCh9zBP
An unquoted semicolon in -DCMAKE_OSX_ARCHITECTURES=arm64;x86_64 is a shell command separator, so the configure step ran 'cmake ... -DCMAKE_OSX_ARCHITECTURES=arm64' and then tried to execute 'x86_64' as a command. Quoting keeps the list intact. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018fcuaJJNPpDCeczXCh9zBP
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.