Merged
Conversation
* this is primarily for conversion from ATS to Docuseal, since these fields would normally just be updated through the Docuseal iframe itself
* use word map to properly display Firstname as First Name, Lastname as Last Name
bernardodsanderson
approved these changes
Mar 4, 2026
|
|
||
| def apply_audience(template, audience) | ||
| return if audience.blank? | ||
| return unless audience.in?(VALID_AUDIENCE_VALUES) |
Collaborator
There was a problem hiding this comment.
[optional] Not sure if we want any kind of warnings or logs if there's an invalid audience?
Collaborator
Author
There was a problem hiding this comment.
Sure I can add a log!
I don't think we need to surface to the user in the UI. This would only be for the conversion process since preferences['submitters_order'] is set elsewhere for the actual UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/templates/pdfendpoint, mapping it topreferences['submitters_order']with allowlist validation against known values(
single_sided, employee_then_manager, manager_then_employee, simultaneous):prefillto strong parameters for template fields, enabling theprefillfield association to persistmanager_firstname→ "Manager First Name") in the template builderhttps://www.loom.com/share/fa10de01b7e5419793e397197e724ffe