Repository navigation
fix(prune-staging): recognise portal uploads by their manifest url - #208
Merged
Merged
Conversation
Portal uploads are stored in staging as "<login>__<file>", not the pool name, so the prune rule could neither tell they were published nor see that an open PR still downloads one (it only compared manifest filename). An open PR such as #206 would have lost its binary after 14 days. Match the url file name too, and count a prefixed upload as promoted when a manifest on main points at it and the pool holds that manifest file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Portal uploads are stored in staging as
<login>__<file>, not the pool name. The prune rule (#207) therefore:filename, not the file theirurldownloads.Open PR #206 (key-dash 0.4.2) downloads exactly such a file, which would have been deleted as stale on 2026-11-07, so the PR could no longer be promoted after merge.
Fix: match the url file name (URL-decoded) as well, and treat a prefixed upload as promoted when a manifest on
mainpoints at it and apt-pool holds that manifest's file.Dry runs:
yuk1-kondo__key-dash_0.4.2-rev1_arm64.deb(used by #206)The other two kept files (a retro-zero test upload and key-dash 0.4.1) are unpublished and not used by any PR, so they are still removed once they are 14 days old.
🤖 Generated with Claude Code