MagicColor: add LandType to Color

[Hanmac]

Part of #8682 and #9532

This adds the basic land type to ColorEnum
to be used for later changes

[Jetz72]

Perhaps call the field "basicLandType" if Colorless doesn't point to Wastes? Might make sense at some point to split some of these constructor parameters out to EnumMaps. The signature is getting a little cluttered.

[fediazgon]

Is there any rationale with not making these enums? There are a bunch of places in the code where we do things like:

saMana.hasParam("ReplaceOnly")

where this could have been an enum. If you need a display name, you can also do:

public enum BasicLandType {
    PLAINS("Plains"),
    ISLAND("Island"),
    SWAMP("Swamp"),
    MOUNTAIN("Mountain"),
    FOREST("Forest");

    private final String displayName;

    BasicLandType(String displayName) {
        this.displayName = displayName;
    }

    public String getDisplayName() {
        return displayName;
    }
}

[Jetz72]

Is there any rationale with not making these enums? There are a bunch of places in the code where we do things like:

saMana.hasParam("ReplaceOnly")

I'm not sure the example here illustrates the potential upside from such an enum. I don't think we have too many parameters or fields that we'd want to be exclusive to basic land types.

[fediazgon]

The main upside I see is discoverability. With something like saMana.hasParam(Param.REPLACE_ONLY), autocomplete makes it much easier to see what parameters are valid. With raw strings, unless you already know the exact value, it’s hard to tell what hasParam can take without searching the codebase.

Note: this is just an example to explain why I think String basicLand should also be an enum.

[tehdiplomat]

Who is going to be responsible for converting all of the scripts into enums? And then keeping those up to date when new scripts are written?

[Hanmac]

the enum discussion is not part of this MR

[Hanmac]

Also part of #9532
I want to clean up the part of updateBasicLandAbilities using Color→LandType