Repository navigation
fix: isolate pre-push Git environment - #47
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Clear the repository-local environment exported by Git before the pre-push hook runs preflight.
Why
In linked worktrees, fixture Git commands can inherit the pushed worktree's GIT_DIR/index and read or modify the wrong repository. Save the hook root, unset the variables returned by
git rev-parse --local-env-vars, then run the existing gate with unchanged marker/ref behavior.Test plan
474dc8a: conflict-free merge; both changed files remain unchanged upstream.Notes for reviewer
Only
tools/scripts/git-hooks/pre-pushandtools/scripts/tests/test-pre-push-hook.shchange. The regression invokes a real hook and safely reads a foreign fixture's absolute Git directory. No gate bypass, pointer change, hook configuration change or dependency on another source contribution.Upstream
fd78ba1separately fixes mutation.sh's temporary-path cleanup trap; that does not fix Git environment contamination and is not included here. Draft while existing full-gate limitations remain.