Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import type { FrontendOnboardingAttempt, FrontendOnboardingInteractionEvent, Fro
import {
buildFrontendOnboardingAnalytics,
FRONTEND_ONBOARDING_FOLLOWUP_MS,
FRONTEND_ONBOARDING_PRODUCTION_HOST,
FRONTEND_ONBOARDING_VERSIONS,
} from './frontend_onboarding_analytics_model.ts'
import { getFrontendOnboardingDailySetupCliEvents } from './frontend_onboarding_daily_setup_cli_outcomes.ts'
Expand Down Expand Up @@ -183,6 +184,7 @@ export function buildFrontendOnboardingHogql(startDate: string, cohortEndDate: s
FROM events
WHERE event IN (${eventAllowlist})
AND JSONExtractString(toString(properties), 'flow') = 'pre_org'
AND JSONExtractString(toString(properties), '$host') = ${sqlStr(FRONTEND_ONBOARDING_PRODUCTION_HOST)}
AND toIntOrZero(toString(properties.onboarding_version)) IN (${versionAllowlist})
AND timestamp >= parseDateTimeBestEffort(${sqlStr(startDate)})
AND timestamp < parseDateTimeBestEffort(${sqlStr(followupEndDate)})
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
export const FRONTEND_ONBOARDING_VERSIONS = [1, 2, 3] as const
export type FrontendOnboardingVersion = typeof FRONTEND_ONBOARDING_VERSIONS[number]
export const FRONTEND_ONBOARDING_FOLLOWUP_MS = 24 * 60 * 60 * 1000
export const FRONTEND_ONBOARDING_PRODUCTION_HOST = ['console', 'capgo', 'app'].join('.')

export type FrontendOnboardingStageKey = 'intent' | 'details' | 'organization' | 'setup'

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import type {
FrontendOnboardingDailySetupCliEvent,
FrontendOnboardingDailySetupCliEventKind,
} from './frontend_onboarding_daily_setup_cli_outcomes_model.ts'
import { FRONTEND_ONBOARDING_PRODUCTION_HOST } from './frontend_onboarding_analytics_model.ts'
import { cloudlogErr } from './logging.ts'
import { queryPosthogHogql } from './posthog_read.ts'

Expand Down Expand Up @@ -76,6 +77,7 @@ export function buildFrontendOnboardingDailySetupCliHogql(
FROM events
WHERE event = 'onboarding_step_viewed'
AND JSONExtractString(toString(properties), 'flow') = 'pre_org'
AND JSONExtractString(toString(properties), '$host') = ${sqlStr(FRONTEND_ONBOARDING_PRODUCTION_HOST)}
AND toIntOrZero(toString(properties.onboarding_version)) = 2
AND JSONExtractString(toString(properties), 'step') = 'setup'
AND timestamp >= parseDateTimeBestEffort(${sqlStr(startDate)})
Expand All @@ -102,6 +104,7 @@ export function buildFrontendOnboardingDailySetupCliHogql(
OR (
selected_events.event IN ('onboarding_step_viewed', 'onboarding_cli_command_copied', 'onboarding_ai_instructions_copied')
AND JSONExtractString(toString(selected_events.properties), 'flow') = 'pre_org'
AND JSONExtractString(toString(selected_events.properties), '$host') = ${sqlStr(FRONTEND_ONBOARDING_PRODUCTION_HOST)}
AND toIntOrZero(toString(selected_events.properties.onboarding_version)) = 2
AND JSONExtractString(toString(selected_events.properties), 'step') = 'setup'
)
Expand Down
1 change: 1 addition & 0 deletions tests/frontend-onboarding-analytics.unit.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ describe('buildFrontendOnboardingHogql', () => {
expect(query).toContain("'onboarding_organization_invite_succeeded'")
expect(query).toContain("'onboarding_technical_invite_succeeded'")
expect(query).toContain('JSONExtractString(toString(properties), \'flow\') = \'pre_org\'')
expect(query).toContain('JSONExtractString(toString(properties), \'$host\') = \'console.capgo.app\'')
expect(query).toContain('toIntOrZero(toString(properties.onboarding_version)) AS onboarding_version')
expect(query).toContain('toIntOrZero(toString(properties.onboarding_version)) IN (1, 2, 3)')
expect(query).not.toContain('toInt64OrZero')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,12 @@ describe('buildFrontendOnboardingDailySetupCliHogql', () => {
const selectedOrderStart = query.indexOf('\n ORDER BY person_id ASC')
const selectedProjection = query.slice(selectedProjectionStart, selectedFromStart)
const selectedEventsFromWhere = query.slice(selectedFromStart, selectedOrderStart)
const selectedCliBranch = selectedEventsFromWhere.match(/AND \(\n([\s\S]*?)\n {8}OR \(/)?.[1] ?? ''
const selectedSetupCopyBranch = selectedEventsFromWhere.match(/OR \(\n([\s\S]*?)\n {8}\)\n {6}\)/)?.[1] ?? ''

expect(setupPeople).toContain('WHERE event = \'onboarding_step_viewed\'')
expect(setupPeople).toContain('JSONExtractString(toString(properties), \'flow\') = \'pre_org\'')
expect(setupPeople).toContain('JSONExtractString(toString(properties), \'$host\') = \'console.capgo.app\'')
expect(setupPeople).toContain('toIntOrZero(toString(properties.onboarding_version)) = 2')
expect(setupPeople).toContain('JSONExtractString(toString(properties), \'step\') = \'setup\'')
expect(setupPeople).toContain('timestamp >= parseDateTimeBestEffort(\'2026-08-01T00:00:00.123Z\')')
Expand All @@ -77,8 +79,11 @@ describe('buildFrontendOnboardingDailySetupCliHogql', () => {
expect(selectedEventsFromWhere).toContain('selected_events.event = \'CLI Command Invoked\'\n OR (')
expect(selectedEventsFromWhere).not.toContain('JSONExtractString(toString(selected_events.properties), \'channel\')')
expect(selectedEventsFromWhere).not.toContain('JSONExtractString(toString(selected_events.properties), \'command_path\') = \'init\'')
expect(selectedCliBranch).toContain('selected_events.event = \'CLI Command Invoked\'')
expect(selectedCliBranch).not.toContain('JSONExtractString(toString(selected_events.properties), \'$host\')')
expect(selectedSetupCopyBranch).toContain('selected_events.event IN (\'onboarding_step_viewed\', \'onboarding_cli_command_copied\', \'onboarding_ai_instructions_copied\')')
expect(selectedSetupCopyBranch).toContain('JSONExtractString(toString(selected_events.properties), \'flow\') = \'pre_org\'')
expect(selectedSetupCopyBranch).toContain('JSONExtractString(toString(selected_events.properties), \'$host\') = \'console.capgo.app\'')
Comment thread
cubic-dev-ai[bot] marked this conversation as resolved.
expect(selectedSetupCopyBranch).toContain('toIntOrZero(toString(selected_events.properties.onboarding_version)) = 2')
expect(selectedSetupCopyBranch).toContain('JSONExtractString(toString(selected_events.properties), \'step\') = \'setup\'')

Expand Down
Loading