Skip to content

fix(stats): address success rate review comments from #2988 - #2990

Draft
riderx wants to merge 1 commit into
mainfrom
cursor/fix-success-rate-review-04fe
Draft

fix(stats): address success rate review comments from #2988#2990
riderx wants to merge 1 commit into
mainfrom
cursor/fix-success-rate-review-04fe

Conversation

@riderx

@riderx riderx commented Aug 11, 2026

Copy link
Copy Markdown
Member

Summary (AI generated)

  • getUpdateStatsCF and get_update_stats() now include apps with install/fail outcomes even when no get event occurred in the snapshot window.
  • Global total is aggregated from all apps in the query result, not only post-filtered rows.
  • Public /data headline + daily success rate now uses the same app_log set/failure event stream as platform/country/version breakdowns.

Motivation (AI generated)

Follow-up to #2988 review comments: the global success rate still dropped install/fail-only apps due to a get > 0 filter, and public headline metrics mixed version_usage with app_log breakdowns.

Business Impact (AI generated)

More accurate global_stats snapshots and internally consistent public success rate numbers across headline and dimensional views.

Test Plan (AI generated)

  • bunx vitest run tests/public-live-update-metrics.unit.test.ts tests/public-stats.unit.test.ts
  • Compare /private/website_stats/live_updates headline vs platform breakdown success rates after deploy
  • Verify next global_stats cron stores success_rate including install/fail-only apps

Generated with AI

Open in Web Open in Cursor 

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Review in cubic

- Include install/fail-only apps in global_stats total (drop get>0 filter)
- Drive public headline+daily from app_log like dimensional breakdowns
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: ef4f36c1-556f-490d-96b2-7065634b8057

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@codspeed-hq

codspeed-hq Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 43 untouched benchmarks
⏩ 2 skipped benchmarks1


Comparing cursor/fix-success-rate-review-04fe (997034b) with main (bc40030)

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants