Skip to content

fix(cli): stop error tracking for missing bundle versions #2973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
posthog-eu wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −9
Draft

fix(cli): stop error tracking for missing bundle versions #2973

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions cli/src/api/versions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import type { SupabaseClient } from '@supabase/supabase-js'
import type { Database } from '../types/supabase.types'
import { log } from '@clack/prompts'
import { Table } from '@sauber/table'
import { CliUserError } from '../shared/cli-user-error'
import { formatError, getHumanDate, invokeCapgoCliApi, readCapgoCliApiErrorPayload } from '../utils'
import { checkVersionNotUsedInChannel } from './channels'

Expand Down Expand Up @@ -80,10 +81,13 @@ export async function deleteAppVersion(
.eq('name', bundle)

if (delAppSpecVersionError) {
const message = `App version ${appid}@${bundle} not found in database`
if (!silent)
log.error(message)
throw new Error(`${message}: ${formatError(delAppSpecVersionError)}`)
log.error(`App version ${appid}@${bundle} not found in database`)
throw new CliUserError('App version not found in database', {
appId: appid,
version: bundle,
detail: formatError(delAppSpecVersionError),
})
}
return
}
Expand All @@ -99,10 +103,13 @@ export async function deleteAppVersion(
supaAnon,
})
if (error) {
const message = `App version ${appid}@${bundle} not found in database`
if (!silent)
log.error(message)
throw new Error(`${message}: ${formatError(error)}`)
log.error(`App version ${appid}@${bundle} not found in database`)
throw new CliUserError('App version not found in database', {
appId: appid,
version: bundle,
detail: formatError(error),
})
}
}

Expand Down Expand Up @@ -225,10 +232,13 @@ export async function getVersionData(
const all = await getActiveAppVersions(apikey, appid, options)
const versionData = all.find(row => row.name === bundle)
if (!versionData) {
const message = `App version ${appid}@${bundle} doesn't exist`
// A named bundle that is not in the active list is a user typo or a version
// that was never uploaded, not a CLI crash. Throw a CliUserError so error
// tracking skips it, and keep the app id and version in `context` (not the
// message) so one problem stays one issue instead of one per version string.
if (!silent)
log.error(message)
throw new Error(message)
log.error(`App version ${appid}@${bundle} doesn't exist`)
throw new CliUserError('App version doesn\'t exist', { appId: appid, version: bundle })
}
return versionData
}
Loading