Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gustavo Nuñez y Ramiro Polverini de Bantics Coop
We had to re run the mongo docker (we had installed in a docker instance because in debian 10 testing are not a candidate in official repo. We tried to install directly via the package but has dependency problems) for expose a volume, then copy the dump, and execute the mongorestore.
sudo docker run -p 27017:27017 -v /home/rfpolverini/repoBantics/mongo/:/etc/mongo --name some-mongo -d mongo:3.4.20
sudo docker exec -i some-mongo mongorestore /etc/mongo/dump
Issue 1
We made the test, trying to acomplish the requeriment of the first issue.
We saw that the genericController implement a generic FilterQuery . The fields of this queryBuilder is defined in each specific controller, then we add the required field in the filterFields array.
We saw too that the buildFilterQuery function had linter error, we redefined it
Issue 2
We try to made a test for this issue, we see that a get in http://localhost:8000/api/admin/billing/getChargeableStudents response with '7' Students, then we expected an array with 7 objects in the response, one for each possible invoice.
We are going Crazy with the async and promises...
We tried to make it Sync Without success because the request allways seems to be async... and the result object is filled empty .
We tried to use async, with await, .then chain, etc.. but nothing seems to work like we excpect.