Tweak echelle code to support different parameterization#8
Draft
Yashvi-Sharma wants to merge 8 commits intomainfrom
Draft
Tweak echelle code to support different parameterization#8Yashvi-Sharma wants to merge 8 commits intomainfrom
Yashvi-Sharma wants to merge 8 commits intomainfrom
Conversation
…ist effect to work with tweaks
…oter_v2 spec mode config with Echelle trace effects
…greater ability to guess cross-disperser.
… calculations. Echellette->Echelle
…elle spectrograph factory.
Yashvi-Sharma
commented
Mar 6, 2026
| def __init__(self, **kwargs): | ||
| super().__init__(**kwargs) | ||
| self.efficiency_generator = self._generate_efficiency_curve_func() | ||
| self.efficiency_generator = self._generate_efficiency_curve_func(DataContainer(filename=kwargs.pop('filename'))) |
Collaborator
Author
There was a problem hiding this comment.
No need to call DataContainer here, the super().init already handles the loading of files specified under 'filename' kwarg. So the trace_params table can be accessed with self.table
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.